Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test timing of SA pull secret creation #24776

Closed
wants to merge 1 commit into from
Closed

Test timing of SA pull secret creation #24776

wants to merge 1 commit into from

Conversation

adambkaplan
Copy link
Contributor

@adambkaplan adambkaplan commented Mar 26, 2020 •
edited

Ensure service account pull secrets are created in 2 seconds or less.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2020
adambkaplan
adambkaplan commented Mar 26, 2020
View reviewed changes
test/extended/controller_manager/pull_secret.go Outdated
sa, err := clusterAdminKubeClient.CoreV1().ServiceAccounts(sa.Namespace).Create(sa)
o.Expect(err).NotTo(o.HaveOccurred())
g.By("waiting for service account's pull secret to be created")
_, _, err = waitForServiceAccountPullSecret(clusterAdminKubeClient, sa.Namespace, sa.Name, 5, time.Second)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfojtik @smarterclayton Is 5 seconds a reasonable maximum to fail on?

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@adambkaplan adambkaplan changed the title WIP - Test timing of service account pull secrets Bug 1765294: Test timing of SA pull secret creation Apr 1, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 1, 2020
@openshift-ci-robot
Copy link

@adambkaplan: This pull request references Bugzilla bug 1765294, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1765294: Test timing of SA pull secret creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan adambkaplan mentioned this pull request Apr 1, 2020
Merged
@adambkaplan adambkaplan changed the title Bug 1765294: Test timing of SA pull secret creation Bug 1785023: Test timing of SA pull secret creation Apr 1, 2020
@openshift-ci-robot
Copy link

@adambkaplan: This pull request references Bugzilla bug 1785023, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1785023: Test timing of SA pull secret creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan
Copy link
Contributor Author

/retest

/assign @bparees
/cc @smarterclayton

bparees
bparees requested changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@bparees bparees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit.

also please run the tests on this PR 4-5 times before merging to confirm we're not introducing a flaky test (i don't know how reliable the 2s timing will be)

test/extended/controller_manager/pull_secret.go Outdated Show resolved Hide resolved
@adambkaplan adambkaplan changed the title Bug 1785023: Test timing of SA pull secret creation Test timing of SA pull secret creation Apr 9, 2020
@openshift-ci-robot
Copy link

@adambkaplan: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Test timing of SA pull secret creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 9, 2020
@bparees
Copy link
Contributor

bparees commented Apr 9, 2020

@adambkaplan please squash and let me know when you've seen 4-5 passing runs and i'll lgtm.

@adambkaplan
Copy link
Contributor Author

/retest

@adambkaplan
Copy link
Contributor Author

/retest

hit by CI issues

@danehans
Copy link
Contributor

@adambkaplan does this PR need to be linked to BZ 1819849?

@adambkaplan
Test timing of SA pull secret creation
11ec288 
* Ensure service account pull secrets are created in 2 seconds or less.
* Dump secrets instead of ocm logs for pull secret controller e2e tests.
@adambkaplan
Copy link
Contributor Author

/retest

@adambkaplan
Copy link
Contributor Author

/retest

/test e2e-gcp

/test e2e-aws-fips

@adambkaplan
Copy link
Contributor Author

/test e2e-gcp

/test e2e-aws-fips

@adambkaplan
Copy link
Contributor Author

/retest

@adambkaplan
Copy link
Contributor Author

/test e2e-aws

/test e2e-gcp

/test e2e-gcp-builds

@adambkaplan
Copy link
Contributor Author

/test e2e-gcp

/test e2e-aws-fips

/test e2e-aws-serial

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 22, 2020 •
edited

@adambkaplan: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-fips 11ec288 link /test e2e-aws-fips

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2020
@openshift-merge-robot
Copy link
Contributor

@adambkaplan: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-cmd 11ec288 link /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adambkaplan
Copy link
Contributor Author

/close

No longer relevant

@openshift-ci-robot
Copy link

@adambkaplan: Closed this PR.

In response to this:

/close

No longer relevant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees bparees requested changes

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@knobunc knobunc Awaiting requested review from knobunc

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@adambkaplan @openshift-ci-robot @bparees @danehans @openshift-bot @openshift-merge-robot