Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1820731 Can't show the message in time #24871

Closed
wants to merge 1 commit into from
Closed

Bug 1820731 Can't show the message in time #24871

wants to merge 1 commit into from

Conversation

emmajiafan
Copy link
Contributor

Remove the test of status.currentPhase.phase.message since the message can't be shown in time , keep the status.name test .

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: emmajiafan
To complete the pull request process, please assign adambkaplan
You can assign the PR to them by writing /assign @adambkaplan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@emmajiafan
Copy link
Contributor Author

@kevinrizza , I fix this bug by removing the check of "status.currentPhase.phase.message" since it can't show in time. Could you help take a look at it please? Thank you!

@openshift-ci-robot
Copy link

@emmajiafan: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-fips 6d33b3d link /test e2e-aws-fips
ci/prow/e2e-gcp 6d33b3d link /test e2e-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2020
@openshift-ci-robot
Copy link

@emmajiafan: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@emmajiafan
Copy link
Contributor Author

close this pr since the fix should merge to 4.4

@emmajiafan emmajiafan closed this May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants