New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1731263: Balance preemption e2e nodes #24947
Bug 1731263: Balance preemption e2e nodes #24947
Conversation
@damemi: This pull request references Bugzilla bug 1731263, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1f9ad12
to
6db1ee9
Compare
So, re-enabled and with these fixes the tests fail with:
Something else I see is that the calculated usage for the balanced pods differs from the usage we calculate when creating the victim pods |
f5d05cd
to
2824c6b
Compare
/retest |
2b16bd1
to
b540d91
Compare
/retest |
b540d91
to
36b09a0
Compare
36b09a0
to
c584cec
Compare
/bugzilla refresh |
@damemi: This pull request references Bugzilla bug 1731263, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind failing-test |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
#24936 has merged the 1.18.2 bump |
@damemi: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
These preemption e2es attempt to create filler "victim" pods that use 60% of a node's available resources, and assumes that with all nodes full, the low priority pod will get evicted.
However, if the nodes have very different usages (say one is at 500/1500 cpu and another is at 1000/1500), then the request of 60% of the low-priority-pod's-node's usage may not fit on one node, but will fit on another and the test fails.
This PR creates balanced pods in these e2es to ensure a level field for the preemption tests.
Upstream: kubernetes/kubernetes#90740