Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1829405: test/extended/operators/operators: Rework "start all core operators" #24948

Merged
merged 1 commit into from May 6, 2020

Conversation

wking
Copy link
Member

@wking wking commented May 5, 2020

Drop namespace from output strings, because ClusterOperator is cluster-scoped.

Shift the available variable down to the block of code that actually consumes it, and convert it from a map to a counter, because we don't care about displaying available operators.

Rename unavailable to the more generic working (to match the existing "still doing work" messages). Working operator may be available but progressing, etc., so unavailable was too specific.

Remove the break from the wait-loop's ClusterOperator iteration. The previous logic would only list the first unavailable operator. With this commit we now list each unavailable operator while we wait.

Reformat the tab-writer block to print each operator and its worst condition. The previous format had columns for progressing and available, but none for degraded status. It also had a single message column, making it unclear which condition's message was being displayed. The new format displays the full type, status, reason, and message of the worst condition for each operator.

The new code also includes the worst condition (or, if all existing conditions for an operator were expected, any missing condition types) in the failing error message. This should be more actionable with less digging than the current messages, which just list the unsettled operator names.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label May 5, 2020
@openshift-ci-robot
Copy link

@wking: This pull request references Bugzilla bug 1829405, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1829405: test/extended/operators/operators: Rework "start all core operators"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 5, 2020
@wking
Copy link
Member Author

wking commented May 5, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 5, 2020
@openshift-ci-robot
Copy link

@wking: This pull request references Bugzilla bug 1829405, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 5, 2020
@wking wking force-pushed the operators-debugging branch 6 times, most recently from b1c5bd4 to a7b435d Compare May 5, 2020 17:18
@wking
Copy link
Member Author

wking commented May 5, 2020

images:

2020/05/05 17:52:55 error: unable to signal to artifacts container to terminate in pod release-latest, triggering deletion: could not run remote command: unable to upgrade connection: container not found ("artifacts")
2020/05/05 17:52:55 error: unable to retrieve artifacts from pod release-latest: could not read gzipped artifacts: unable to upgrade connection: container not found ("artifacts")

/retest

@wking wking force-pushed the operators-debugging branch 2 times, most recently from 8f02850 to fe2a717 Compare May 6, 2020 00:18
@wking
Copy link
Member Author

wking commented May 6, 2020

I'd flipped the expected sense on Degraded (fixed with a7b435d -> fe2a717), but it shows the output formatting:

fail [github.com/openshift/origin/test/extended/operators/operators.go:156]: May  5 22:14:53.039: Some cluster operators never became available authentication (Degraded=False AsExpected: <nil>), cloud-credential (Degraded=False NoCredentialsFailing: No credentials requests reporting errors.), ...

@wking
Copy link
Member Author

wking commented May 6, 2020

Remaining CI failures look unrelated. @bparees, want to take a look and approve if you like it?

/assign @bparees

Copy link
Contributor

@bparees bparees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, generally looks good. Some naming nits and do you have an example of the new output when this test fails?

test/extended/operators/operators.go Outdated Show resolved Hide resolved
test/extended/operators/operators.go Outdated Show resolved Hide resolved
test/extended/operators/operators.go Outdated Show resolved Hide resolved
test/extended/operators/operators.go Outdated Show resolved Hide resolved
@wking
Copy link
Member Author

wking commented May 6, 2020

I pushed fe2a717 -> 5819963 to fig working -> unready and use badConditions. There's an example of the "failure" output linked from this earlier comment.

test/extended/operators/operators.go Outdated Show resolved Hide resolved
test/extended/operators/operators.go Outdated Show resolved Hide resolved
@bparees
Copy link
Contributor

bparees commented May 6, 2020

There's an example of the "failure" output linked from this earlier comment.

thanks, that looks nice

Drop namespace from output strings, because ClusterOperator is
cluster-scoped [1].

Shift the 'available' variable down to the block of code that actually
consumes it, and convert it from a map to a counter, because we don't
care about displaying available operators.

Rename 'unavailable' to the more generic 'unready'.  Also rephrase the
"still doing work" message to hinge on "ready", because "working" can
sound like "as expectd" not "still has stuff to do" [1].  An unready
operator may be available but progressing, etc., so 'unavailable' was
too specific.

Remove the 'break' from the wait-loop's ClusterOperator iteration.
The previous logic would only list the first unavailable operator.
With this commit we now list each unavailable operator while we wait.

Reformat the tab-writer block to print each operator and its worst
condition.  The previous format had columns for progressing and
available, but none for degraded status.  It also had a single message
column, making it unclear which condition's message was being
displayed.  The new format displays the full type, status, reason, and
message of the worst condition for each operator.

The new code also includes the worst condition (or, if all existing
conditions for an operator were expected, any missing condition types)
in the failing error message.  This should be more actionable with
less digging than the current messages, which just list the unsettled
operator names [2].

[1]: https://github.com/openshift/api/blob/b98a784d8e6dc93c416b40cdf54bf3102f2b61d2/config/v1/types_cluster_operator.go#L9
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1829405#c1
@bparees
Copy link
Contributor

bparees commented May 6, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit dfd05bf into openshift:master May 6, 2020
@openshift-ci-robot
Copy link

@wking: All pull requests linked via external trackers have merged: openshift/origin#24948. Bugzilla bug 1829405 has been moved to the MODIFIED state.

In response to this:

Bug 1829405: test/extended/operators/operators: Rework "start all core operators"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the operators-debugging branch May 6, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants