[release-3.11] Bug 1884422: Backport router hostindex fixes #25891
Conversation
Ensure that a passthrough route displaces any path-based TLS routes with the same host, because passthrough is incompatible with path-based routing. This commit fixes bug 1691190. https://bugzilla.redhat.com/show_bug.cgi?id=1691190 * pkg/router/controller/hostindex/activation.go (hasExistingMatch): Return true if both routes are TLS and the existing route is a passthrough route. * pkg/router/controller/hostindex/hostindex_test.go (Test_hostIndex): Verify that a passthrough route displaces path-based TLS routes with the same host, but does not displace non-TLS routes.
Just as a passthrough route displaces any path-based TLS routes with the same host, a path-based TLS route displaces any passthrough route with the same host. Follow-up to commit 65e784fe491ef02c4db0346348e6ac6192d68e30. * pkg/router/controller/hostindex/activation.go (hasExistingMatch): Return true if both routes are TLS and *either* route is passthrough. * pkg/router/controller/hostindex/hostindex_test.go (Test_hostIndex): Verify that a path-based TLS route displaces passthrough routes with the same host.
openshift-ci-robot
added
bugzilla/severity-high
|
@Miciah: This pull request references Bugzilla bug 1884422, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Miciah: This pull request references Bugzilla bug 1884422. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@Miciah: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Miciah: An error was encountered searching for bug 1884422 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
response code 502 not 200
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
lifecycle/rotten
|
/retest |
|
Not sure if this the cause for both test failures: error: shallow cloning repository "https://github.com/sclorg/nodejs-ex" to "/tmp/gen052590313" failed: fatal: unable to access 'https://github.com/sclorg/nodejs-ex/': Failed connect to github.com:443; Connection timed out /retest |
|
/retest |
|
/bugzilla refresh |
|
@Miciah: This pull request references Bugzilla bug 1884422, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test unit |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: candita, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Miciah: All pull requests linked via external trackers have merged: Bugzilla bug 1884422 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Backport openshift/router#57 and openshift/router#59.
hostindex: Passthrough displaces path-based TLS
Ensure that a passthrough route displaces any path-based TLS routes with the same host, because passthrough is incompatible with path-based routing.
pkg/router/controller/hostindex/activation.go(hasExistingMatch): Return true if both routes are TLS and the existing route is a passthrough route.pkg/router/controller/hostindex/hostindex_test.go(Test_hostIndex): Verify that a passthrough route displaces path-based TLS routes with the same host, but does not displace non-TLS routes.hostindex: Path-based TLS displaces passthrough
Just as a passthrough route displaces any path-based TLS routes with the same host, a path-based TLS route displaces any passthrough route with the same host.
pkg/router/controller/hostindex/activation.go(hasExistingMatch): Return true if both routes are TLS and either route is passthrough.pkg/router/controller/hostindex/hostindex_test.go(Test_hostIndex): Verify that a path-based TLS route displaces passthrough routes with the same host.