New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1952457: Re-enable crictl node test #26320
Bug 1952457: Re-enable crictl node test #26320
Conversation
cb3a6e5
to
b4f328c
Compare
/test e2e-metal-ipi-ovn-ipv6 |
The test is using Kubernetes v1.21.1, so we may have to wait until v1.22.0 has been released as well as the dependency has been updated. |
/approve |
b4f328c
to
450716e
Compare
Test still use 1.21.1, waiting a bit more until we run on 1.22 🙃 |
The corresponding upstream PR has been merged which should make the test more robust: kubernetes/kubernetes#101866 This means we can now re-enable the test for the Kubernetes `master`. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
450716e
to
bf7f113
Compare
/test e2e-agnostic-cmd |
/retest |
/test e2e-agnostic-cmd |
The test gets now automatically skipped, see: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/26320/pull-ci-openshift-origin-master-e2e-gcp/1432249603821932544 This is ready for review and merge. |
PTAL @smarterclayton |
@saschagrunert: This pull request references Bugzilla bug 1952457, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
/retest-required |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, rphillips, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@saschagrunert: An error was encountered querying GitHub for users with public email (schoudha@redhat.com) for bug 1952457 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
e2e-gcp test passed but prow does not report the result back |
/override ci/prow/e2e-gcp |
@saschagrunert: saschagrunert unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-gcp |
@saschagrunert: saschagrunert unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/test e2e-gcp |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/test e2e-gcp |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@saschagrunert: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test e2e-aws-fips |
@saschagrunert: All pull requests linked via external trackers have merged: Bugzilla bug 1952457 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hm, what's the difference between the CI running here as presubmit and the periodic? Because the test passed (got excluded) on the PR. |
I can't see much difference, presubmits installs Loki for logging but I don't see what that changes. presubmits here: https://github.com/openshift/release/blob/master/ci-operator/config/openshift/origin/openshift-origin-master.yaml#L86-L89 Looking at the test code I can't figure out why the IP is available in crictl.go ("Ran x on 10.0.0.5:22") but the IP is missing in the SSH method -- unless we're somehow hitting the kube bastion code on the CI builds? But I'm not sure how to tell. origin/vendor/k8s.io/kubernetes/test/e2e/framework/ssh/ssh.go Lines 208 to 214 in a28c0b3
|
Usually the test should skip earlier because no SSH'able nodes are found. But the result now assumes that ssh is running via the internal node IPs. Hm, hm… we made the test host-local in kubernetes/kubernetes#103640, but this will land in v1.23.0.
|
Is there a way to fix it, or can we re-disable the test? I filed https://bugzilla.redhat.com/show_bug.cgi?id=2000589 for this problem if you need a BZ |
Yes, let's revert for now. |
The corresponding upstream PR has been merged which should make the test
more robust: kubernetes/kubernetes#101866
This means we can now re-enable the test for the Kubernetes
master
.