bug 1987230: Single node apirequestscount upper bounds #26354

ingvagabund · 2021-07-28T10:56:52Z

Increasing the bounds based on

aws-ebs-csi-driver-operator, watchrequestcount=284, upperbound=216, ratio=1.3148148148148149
cloud-credential-operator, watchrequestcount=127, upperbound=124, ratio=1.0241935483870968
cluster-monitoring-operator, watchrequestcount=70, upperbound=64, ratio=1.09375
cluster-storage-operator, watchrequestcount=403, upperbound=310, ratio=1.3
csi-snapshot-controller-operator, watchrequestcount=197, upperbound=104, ratio=1.8942307692307692
etcd-operator, watchrequestcount=328, upperbound=250, ratio=1.312
kube-storage-version-migrator-operator, watchrequestcount=136, upperbound=72, ratio=1.8888888888888888
openshift-apiserver-operator, watchrequestcount=514, upperbound=452, ratio=1.1371681415929205
openshift-config-operator, watchrequestcount=99, upperbound=94, ratio=1.053191489361702
openshift-controller-manager-operator, watchrequestcount=360, upperbound=298, ratio=1.2080536912751678
service-ca-operator, watchrequestcount=261, upperbound=214, ratio=1.219626168224299

to make the test less blocking. We may decrease the bounds later once the number of api requests is reduced.

omertuc · 2021-07-28T11:20:06Z

test/extended/apiserver/api_requests.go

+
+		var upperBound platformUpperBound
+
+		if infra.Status.ControlPlaneTopology == v1.SingleReplicaTopologyMode {


Maybe a comment / commit message explaining why SNO needs higher bounds? I guess even "we're not sure" will be better than nothing. Since it's not really obvious.

All the upper bounds are measured experimentally. So "we are not sure" in every case. It's all a guess based on the CI measurements. The entire test should be treated as such. The main idea is to have a test which will tell us if the upper bound was exceeded ad more importantly how much. To see if the increase is linear or exponential.

Fair enough

eranco74

/lgtm

openshift-ci · 2021-07-29T09:36:59Z

@ingvagabund: This pull request references Bugzilla bug 1987230, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @kasturinarra

In response to this:

bug 1987230: Single node apirequestscount upper bounds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ingvagabund · 2021-07-29T09:38:23Z

/retest

soltysh · 2021-07-29T09:52:26Z

test/extended/apiserver/api_requests.go

@@ -10,6 +10,7 @@ import (
 	o "github.com/onsi/gomega"
 	apiserverv1 "github.com/openshift/api/apiserver/v1"
 	configv1 "github.com/openshift/api/config/v1"
+	v1 "github.com/openshift/api/config/v1"


Nit: you have these duplicated

soltysh

/lgtm
/approve

openshift-ci · 2021-07-29T10:02:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74, ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~test/extended/OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ingvagabund · 2021-07-29T11:28:15Z

/retest

omertuc · 2021-07-29T11:34:51Z

/test e2e-gcp

omertuc · 2021-07-29T11:40:57Z

/test e2e-metal-ipi-ovn-ipv6

openshift-bot · 2021-07-29T13:05:10Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T13:42:00Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T13:53:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T14:29:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T14:41:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T18:17:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T18:29:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T18:41:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T18:53:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T19:06:10Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T19:17:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T19:29:56Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T19:41:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T19:54:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T20:06:00Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T20:17:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T20:29:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T20:41:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T20:53:56Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T21:05:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T21:18:56Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T21:30:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T21:43:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T22:09:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T22:33:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-07-29T22:37:44Z

@ingvagabund: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-agnostic-cmd	`5fcd164`	link	`/test e2e-agnostic-cmd`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-07-29T22:45:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T22:58:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T23:11:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-29T23:25:00Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-30T00:03:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-30T00:17:00Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-07-30T00:18:59Z

@ingvagabund: All pull requests linked via external trackers have merged:

Bugzilla bug 1987230 has been moved to the MODIFIED state.

In response to this:

bug 1987230: Single node apirequestscount upper bounds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy paste aws upper bounds for single node

e335667

openshift-ci bot requested review from ironcladlou and knobunc July 28, 2021 11:00

omertuc reviewed Jul 28, 2021

View reviewed changes

eranco74 reviewed Jul 28, 2021

View reviewed changes

openshift-ci bot assigned eranco74 Jul 28, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021

ingvagabund changed the title ~~Single node apirequestscount upper bounds~~ bug 1987230: Single node apirequestscount upper bounds Jul 29, 2021

openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 29, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 29, 2021

openshift-ci bot requested a review from kasturinarra July 29, 2021 09:37

soltysh reviewed Jul 29, 2021

View reviewed changes

Set single node upper bounds

5fcd164

ingvagabund force-pushed the single-node-apirequestscount-upper-bounds branch from 1ab9125 to 5fcd164 Compare July 29, 2021 09:55

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2021

soltysh approved these changes Jul 29, 2021

View reviewed changes

openshift-ci bot assigned soltysh Jul 29, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2021

openshift-merge-robot merged commit 1cd7b4f into openshift:master Jul 30, 2021

ingvagabund deleted the single-node-apirequestscount-upper-bounds branch July 30, 2021 07:48


		var upperBound platformUpperBound

		if infra.Status.ControlPlaneTopology == v1.SingleReplicaTopologyMode {

Navigation Menu

bug 1987230: Single node apirequestscount upper bounds #26354

bug 1987230: Single node apirequestscount upper bounds #26354

Conversation

ingvagabund commented Jul 28, 2021

omertuc Jul 28, 2021

Choose a reason for hiding this comment

ingvagabund Jul 28, 2021 • edited

Choose a reason for hiding this comment

omertuc Jul 28, 2021

Choose a reason for hiding this comment

eranco74 left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jul 29, 2021

ingvagabund commented Jul 29, 2021

soltysh Jul 29, 2021

Choose a reason for hiding this comment

soltysh left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jul 29, 2021

ingvagabund commented Jul 29, 2021

omertuc commented Jul 29, 2021

omertuc commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-ci bot commented Jul 29, 2021 • edited

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 29, 2021

openshift-bot commented Jul 30, 2021

openshift-bot commented Jul 30, 2021

openshift-ci bot commented Jul 30, 2021

ingvagabund Jul 28, 2021 •

edited

openshift-ci bot commented Jul 29, 2021 •

edited