New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/extended/builds: handle new step logging #26464
tests/extended/builds: handle new step logging #26464
Conversation
Buildah 1.22 modifies how steps are logged for builds. While older builds would see STEP 1: FROM ... AS test in our multistage build test, 1.22 and later will produce [1/2] STEP 1/2: FROM ... AS test in the first stage of a two-stage build, when the first stage has two instructions in it. Update our expectations to accept either version. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
/lgtm |
/assign @gabemontero |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@nalind: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/cherry-pick release-4.9 |
@jkhelil: new pull request created: #26606 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Buildah 1.22 modifies how steps are logged for builds. While older builds would see
in our multistage build test, 1.22 and later will produce
in the first stage of a two-stage build, when the first stage has two instructions in it. Update our expectations to accept either version.