Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 Whereabouts e2e tests #26514

Merged

Conversation

nicklesimba
Copy link
Contributor

@nicklesimba nicklesimba commented Oct 7, 2021

Created 2 e2e tests for whereabouts.

The first makes 4 pods with a whereabouts IPAM that only allows 3 IP addresses. The expected result is that the first 3 come up successfully and the 4th pod doesn't.

The second makes 2 pods, one with a parameter to sleep for 20 seconds 5 seconds (configurable via whereabouts-race-sleepy.yml, located in test/extended/testdata/net-attach-defs) after getting its IP address, and the second with no such parameter. The expected result is that a race condition should not occur on working code, and both pods should be assigned unique IPs.

@dougbtv
Copy link
Member

dougbtv commented Oct 7, 2021

Just a note that this is a fresh PR (due to some issues rebasing), and Nikhil and I had reviewed the original e2e test. I'll continue with a review for the race condition portion, too.

@nicklesimba
Copy link
Contributor Author

/retest-required

@dougbtv
Copy link
Member

dougbtv commented Oct 7, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2021
@nicklesimba
Copy link
Contributor Author

/retest-required

1 similar comment
@nicklesimba
Copy link
Contributor Author

/retest-required

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2021
@nicklesimba nicklesimba force-pushed the whereabouts-e2e-test branch 3 times, most recently from c761f04 to f39eb26 Compare October 15, 2021 14:42
@nicklesimba
Copy link
Contributor Author

Fixed a typo that was causing a couple of tests to fail

@nicklesimba nicklesimba force-pushed the whereabouts-e2e-test branch 2 times, most recently from 581e84f to 78fd51c Compare October 19, 2021 16:02
@nicklesimba
Copy link
Contributor Author

Altered yaml files to work with configurable sleep_for_race parameter.

@nicklesimba
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2021

@nicklesimba: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-cmd bcbf490 link false /test e2e-agnostic-cmd
ci/prow/e2e-aws-cgroupsv2 bcbf490 link false /test e2e-aws-cgroupsv2
ci/prow/e2e-aws-single-node bcbf490 link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicklesimba
Copy link
Contributor Author

/retest-required

@dougbtv
Copy link
Member

dougbtv commented Nov 10, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2021
@knobunc
Copy link
Contributor

knobunc commented Nov 15, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, knobunc, nicklesimba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5302e1e into openshift:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants