New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 2 Whereabouts e2e tests #26514
Added 2 Whereabouts e2e tests #26514
Conversation
Just a note that this is a fresh PR (due to some issues rebasing), and Nikhil and I had reviewed the original e2e test. I'll continue with a review for the race condition portion, too. |
/retest-required |
/lgtm |
/retest-required |
1 similar comment
/retest-required |
198b5c1
to
418865b
Compare
c761f04
to
f39eb26
Compare
Fixed a typo that was causing a couple of tests to fail |
581e84f
to
78fd51c
Compare
78fd51c
to
bcbf490
Compare
Altered yaml files to work with configurable sleep_for_race parameter. |
/retest-required |
@nicklesimba: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, knobunc, nicklesimba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Created 2 e2e tests for whereabouts.
The first makes 4 pods with a whereabouts IPAM that only allows 3 IP addresses. The expected result is that the first 3 come up successfully and the 4th pod doesn't.
The second makes 2 pods, one with a parameter to sleep for
20 seconds5 seconds (configurable viawhereabouts-race-sleepy.yml
, located intest/extended/testdata/net-attach-defs
) after getting its IP address, and the second with no such parameter. The expected result is that a race condition should not occur on working code, and both pods should be assigned unique IPs.