Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2011293: add default search image registry test to build e2es #26530

Conversation

gabemontero
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Oct 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2021

@gabemontero: This pull request references Bugzilla bug 2011293, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jitendar-singh

In response to this:

Bug 2011293: add default search image registry test to build e2es

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 19, 2021
@gabemontero
Copy link
Contributor Author

this new test should not pass until openshift/builder#266 merges

/assign @adambkaplan
need OWNER approve minimally

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

hmm ... must have a typo or missed a step with my new test here:

fail [github.com/openshift/origin/test/extended/util/framework.go:1483]: Test Panicked: Asset test/extended/testdata/builds/test-build-search-registries.json not found

@gabemontero
Copy link
Contributor Author

hmm ... must have a typo or missed a step with my new test here:

fail [github.com/openshift/origin/test/extended/util/framework.go:1483]: Test Panicked: Asset test/extended/testdata/builds/test-build-search-registries.json not found

yep I created a .yaml file, not a .json file :-)

@gabemontero
Copy link
Contributor Author

more typos / errors in my PR:

Error from server (Forbidden): buildconfigs.build.openshift.io "docker-build" is forbidden: buildconfigs.build.openshift.io "docker-build" not found

and

fail [github.com/openshift/origin/test/extended/builds/docker_pullsearch.go:42]: Unexpected error:
    <*errors.errorString | 0xc001d80020>: {
        s: "Build path output did not match expected format 'build/name' : \"\"",
    }
    Build path output did not match expected format 'build/name' : ""
occurred

@gabemontero
Copy link
Contributor Author

bump @adambkaplan all green for the new e2e for build default search registries

test/extended/builds/docker_pullsearch.go Outdated Show resolved Hide resolved
spec:
source:
# ubi8/ubi:latest only resolves to an image on registry.redhat.io or registry.access.redhat.com.
dockerfile: FROM ubi8/ubi:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add this to the list of allowed images. This may require some level of scrutiny because this test covers functionality that impacts disconnected use cases:

https://github.com/openshift/origin/blob/master/test/extended/util/image/image.go

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I picked ubi8/ubi because it was already being used elsewhere: https://github.com/openshift/origin/blob/master/test/extended/testdata/builds/test-build-proxy.yaml#L101

you in fact introduced that with bb06313

And that PR #25778 merged in April, at which point https://github.com/openshift/origin/blob/master/test/extended/util/image/image.go was in full throttle, reviewing its git history

So either we overlooked the mirroring hoopla back then, or ubi8/ubi is so core/essential it gets pulled in elsewhere.

But if it was an oversight, I'm more inclined to use the busybox entry already in there, k8s.gcr.io/e2e-test-images/busybox:1.29-1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the busybox image breaks the premise of the test. k8s.gcr.io is not a container registry on our search list, and moreover busybox is a default image on Docker Hub.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So either we overlooked the mirroring hoopla back then, or ubi8/ubi is so core/essential it gets pulled in elsewhere.

It's possible the ubi layers are present in other images we use. That would depend on a lot of things.
Feels like there was an oversight here, because we indirectly reference the image in our test. This is also explicitly a part of the build suite, which means it isn't run in the normal conformance test.

I think we are OK merging here, then having a follow-up PR that adds the image to the mirror process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the busybox image breaks the premise of the test. k8s.gcr.io is not a container registry on our search list, and moreover busybox is a default image on Docker Hub.

duh - wasn't thinking :-/ thanks @adambkaplan

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So either we overlooked the mirroring hoopla back then, or ubi8/ubi is so core/essential it gets pulled in elsewhere.

It's possible the ubi layers are present in other images we use. That would depend on a lot of things. Feels like there was an oversight here, because we indirectly reference the image in our test. This is also explicitly a part of the build suite, which means it isn't run in the normal conformance test.

I think we are OK merging here, then having a follow-up PR that adds the image to the mirror process.

sounds like a plan thanks

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

unrelated flakes in e2e-gcp-builds

our new test, which is the only thing this PR touches, still passes:

`

: [sig-builds][Feature:Builds][pullsearch] docker build where the registry is not specified Building from a Dockerfile whose FROM image ref does not specify the image registry should create a docker build that has buildah search from our predefined list of image registries and succeed [Suite:openshift/conformance/parallel] 34s

`

@gabemontero
Copy link
Contributor Author

/retest

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor Author

non sig-build flakes have been hitting e2e-gcp-builds

our new test here is passing

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c0eae4b into openshift:master Nov 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2021

@gabemontero: All pull requests linked via external trackers have merged:

Bugzilla bug 2011293 has been moved to the MODIFIED state.

In response to this:

Bug 2011293: add default search image registry test to build e2es

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the bld-def-srch-image-regs-e2es branch November 4, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants