New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2011293: add default search image registry test to build e2es #26530
Bug 2011293: add default search image registry test to build e2es #26530
Conversation
@gabemontero: This pull request references Bugzilla bug 2011293, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this new test should not pass until openshift/builder#266 merges /assign @adambkaplan |
638bcaf
to
34ee055
Compare
34ee055
to
9ff5c3b
Compare
/retest |
hmm ... must have a typo or missed a step with my new test here:
|
9ff5c3b
to
4b5ee1c
Compare
yep I created a .yaml file, not a .json file :-) |
more typos / errors in my PR:
and
|
4b5ee1c
to
f1cc3b0
Compare
bump @adambkaplan all green for the new e2e for build default search registries |
spec: | ||
source: | ||
# ubi8/ubi:latest only resolves to an image on registry.redhat.io or registry.access.redhat.com. | ||
dockerfile: FROM ubi8/ubi:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add this to the list of allowed images. This may require some level of scrutiny because this test covers functionality that impacts disconnected use cases:
https://github.com/openshift/origin/blob/master/test/extended/util/image/image.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I picked ubi8/ubi because it was already being used elsewhere: https://github.com/openshift/origin/blob/master/test/extended/testdata/builds/test-build-proxy.yaml#L101
you in fact introduced that with bb06313
And that PR #25778 merged in April, at which point https://github.com/openshift/origin/blob/master/test/extended/util/image/image.go was in full throttle, reviewing its git history
So either we overlooked the mirroring hoopla back then, or ubi8/ubi is so core/essential it gets pulled in elsewhere.
But if it was an oversight, I'm more inclined to use the busybox entry already in there, k8s.gcr.io/e2e-test-images/busybox:1.29-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the busybox image breaks the premise of the test. k8s.gcr.io
is not a container registry on our search list, and moreover busybox
is a default image on Docker Hub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So either we overlooked the mirroring hoopla back then, or ubi8/ubi is so core/essential it gets pulled in elsewhere.
It's possible the ubi layers are present in other images we use. That would depend on a lot of things.
Feels like there was an oversight here, because we indirectly reference the image in our test. This is also explicitly a part of the build suite, which means it isn't run in the normal conformance test.
I think we are OK merging here, then having a follow-up PR that adds the image to the mirror process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the busybox image breaks the premise of the test.
k8s.gcr.io
is not a container registry on our search list, and moreoverbusybox
is a default image on Docker Hub.
duh - wasn't thinking :-/ thanks @adambkaplan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So either we overlooked the mirroring hoopla back then, or ubi8/ubi is so core/essential it gets pulled in elsewhere.
It's possible the ubi layers are present in other images we use. That would depend on a lot of things. Feels like there was an oversight here, because we indirectly reference the image in our test. This is also explicitly a part of the build suite, which means it isn't run in the normal conformance test.
I think we are OK merging here, then having a follow-up PR that adds the image to the mirror process.
sounds like a plan thanks
8454570
to
f529a25
Compare
/retest |
unrelated flakes in e2e-gcp-builds our new test, which is the only thing this PR touches, still passes: `
` |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
13 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
non sig-build flakes have been hitting e2e-gcp-builds our new test here is passing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@gabemontero: All pull requests linked via external trackers have merged: Bugzilla bug 2011293 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.