Bug 2060498: only add failure when no event was found for the target revision #26880
Conversation
openshift-ci
bot
added
the
approved
The static pod synthetic test looks for a message specifying the explicit revision, but it added a failure for each and every event that was for another revision. This moves the failure adding to the outer loop.
|
/lgtm /cherrypick release-4.10 I think this is worth fixing in a 4.10.z |
|
@deads2k: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
stbenjam
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
stbenjam
changed the title
openshift-ci
bot
added
bugzilla/severity-medium
|
@stbenjam: This pull request references Bugzilla bug 2060498, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@stbenjam: All pull requests linked via external trackers have merged: Bugzilla bug 2060498 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@deads2k: new pull request created: #26881 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stbenjam @deads2k I'm from the SDN team and we've been investigating CI issues that appear more often with OVN as our CNI than with SDN. So, I've analyzed two cases where the test from this PR should (in my opinion) pass, while it does not: @stbenjam could you give my analysis a quick look and see if there's anything suspicious? Thanks! |
The static pod synthetic test looks for a message specifying the
explicit revision, but it added a failure for each and every event that
was for another revision. This moves the failure adding to the outer
loop.