Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add networking test for invalid external gateway #26883

Merged
merged 1 commit into from Apr 5, 2022
Merged

Add networking test for invalid external gateway #26883

merged 1 commit into from Apr 5, 2022

Conversation

pperiyasamy
Copy link
Member

This validates pod creation fails when supplying an external gateway
address to the namespace that does not match the address family
of the pod.

This PR is continuation of this e2e test (ovn-org/ovn-kubernetes#1881) in ovn-kubernetes.

Signed-off-by: Periyasamy Palanisamy pepalani@redhat.com

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 4, 2022
@openshift-ci openshift-ci bot requested review from dcbw and sosiouxme March 4, 2022 14:20
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

Hi @pperiyasamy. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pperiyasamy
Copy link
Member Author

/cc @msherif1234 @fedepaol

@msherif1234
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2022
@pperiyasamy
Copy link
Member Author

/retest

@pperiyasamy
Copy link
Member Author

/test e2e-aws-single-node

@pperiyasamy
Copy link
Member Author

/assign @adambkaplan

adambkaplan
adambkaplan requested changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert to approve this - please assign someone from the relevant Networking team.

test/extended/networking/external_gateway.go
It("Should validate failure if an external gateway address does not match the address family of the pod", func() {
err := createPod(f.ClientSet, f.Namespace.Name, "test-valid-gateway-pod")
expectNoError(err)
makeNamespaceWithExternalGatewaySet(f, "fd00:10:244:2::6")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a comment explaining why this IPv6 address is being used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, done.

test/extended/networking/external_gateway.go Outdated
"context"
"time"

. "github.com/onsi/ginkgo"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ginkgo imports typically have an explicit prefix

Suggested change
. "github.com/onsi/ginkgo"
g "github.com/onsi/ginkgo"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@pperiyasamy
Add networking test for invalid external gateway
466706f 
This validates pod creation fails when supplying an external gateway
address to the namespace that does not match the address family
of the pod.

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
@pperiyasamy
Copy link
Member Author

/assign @dcbw

@dcbw
Copy link
Member

dcbw commented Mar 14, 2022

/lgtm
/approve
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2022
adambkaplan
adambkaplan approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Per @dcbw

@pperiyasamy
Copy link
Member Author

/assign @danwinship @msherif1234 @JacobTanenbaum

@vpickard
Copy link

@adambkaplan Can you please apply the approve label again? It looks like the bot did not catch your last one? Thanks

@vpickard
Copy link

/refresh

@adambkaplan
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, dcbw, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2022

@pperiyasamy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 39578c6 into openshift:master Apr 5, 2022
@pperiyasamy pperiyasamy deleted the invalid-ext-gateway-test branch April 5, 2022 08:19
@stbenjam stbenjam mentioned this pull request Apr 6, 2022
Merged
@pperiyasamy pperiyasamy restored the invalid-ext-gateway-test branch April 6, 2022 15:18
@pperiyasamy pperiyasamy deleted the invalid-ext-gateway-test branch June 27, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@dcbw dcbw Awaiting requested review from dcbw

@sosiouxme sosiouxme Awaiting requested review from sosiouxme

@fedepaol fedepaol Awaiting requested review from fedepaol

@msherif1234 msherif1234 Awaiting requested review from msherif1234

Assignees

@adambkaplan adambkaplan

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pperiyasamy @msherif1234 @dcbw @vpickard @adambkaplan @openshift-bot @openshift-merge-robot