Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2085997: explicit timeout for the etcd scaling test #27216

Merged

Conversation

p0lyn0mial
Copy link
Contributor

on libvirt the etcd is able to vertically scale up and down with a single node test seems to be interrupted after 15 minutes even though the global timeout for the suite is set (https://github.com/openshift/origin/blob/master/cmd/openshift-tests/e2e.go#L124). This PR sets the timeout explicitly for the test just in case something gets in the way and overwrites the global timeout for the suite.

for example:
https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-multiarch-master-nightly-4.11-ocp-e2e-serial-remote-libvirt-ppc64le/1533524212742885376

@p0lyn0mial
Copy link
Contributor Author

/assign @soltysh

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2022

@p0lyn0mial: This pull request references Bugzilla bug 2085997, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @geliu2016

In response to this:

Bug 2085997: explicit timeout for the etcd scaling test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2022
@soltysh
Copy link
Member

soltysh commented Jun 7, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 5d2cace and 8 for PR HEAD a8c4151 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 5d2cace and 7 for PR HEAD a8c4151 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5d2cace and 6 for PR HEAD a8c4151 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD a93ac08 and 5 for PR HEAD a8c4151 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD a93ac08 and 4 for PR HEAD a8c4151 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a93ac08 and 3 for PR HEAD a8c4151 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 08eb779 and 2 for PR HEAD a8c4151 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@p0lyn0mial: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node a8c4151 link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 08eb779 and 1 for PR HEAD a8c4151 in total

@openshift-merge-robot openshift-merge-robot merged commit 4f799c0 into openshift:master Jun 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@p0lyn0mial: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2085997 has not been moved to the MODIFIED state.

In response to this:

Bug 2085997: explicit timeout for the etcd scaling test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants