Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2084361: Print error msg before os.Exit() #27230

Merged
merged 1 commit into from Jun 9, 2022
Merged

Bug 2084361: Print error msg before os.Exit() #27230

merged 1 commit into from Jun 9, 2022

Conversation

jluhrsen
Copy link
Contributor

@jluhrsen jluhrsen commented Jun 7, 2022

Signed-off-by: Jamo Luhrsen jluhrsen@gmail.com

@jluhrsen
Print error msg before os.Exit()
e4869ed 
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@openshift-ci openshift-ci bot requested review from mfojtik and pweil- June 7, 2022 20:39
wking
wking approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2022
@stbenjam
Copy link
Member

stbenjam commented Jun 7, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jluhrsen, stbenjam, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2022
@wking
Copy link
Member

wking commented Jun 7, 2022

/retitle Bug 2084361: Print error msg before os.Exit()

@openshift-ci openshift-ci bot changed the title Print error msg before os.Exit() Bug 2084361: Print error msg before os.Exit() Jun 7, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2022

@jluhrsen: This pull request references Bugzilla bug 2084361, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 2084361: Print error msg before os.Exit()

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 7, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD a93ac08 and 8 for PR HEAD e4869ed in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD a93ac08 and 7 for PR HEAD e4869ed in total

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Jun 8, 2022

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a93ac08 and 6 for PR HEAD e4869ed in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 08eb779 and 5 for PR HEAD e4869ed in total

@jluhrsen jluhrsen closed this Jun 8, 2022
@jluhrsen jluhrsen reopened this Jun 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@jluhrsen: This pull request references Bugzilla bug 2084361. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 2084361: Print error msg before os.Exit()

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@jluhrsen: This pull request references Bugzilla bug 2084361, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 2084361: Print error msg before os.Exit()

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 08eb779 and 4 for PR HEAD e4869ed in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 08eb779 and 3 for PR HEAD e4869ed in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 4f799c0 and 2 for PR HEAD e4869ed in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2022

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 e4869ed link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn-rt-upgrade e4869ed link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-single-node-upgrade e4869ed link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-agnostic-cmd e4869ed link false /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6c2ae5b into openshift:master Jun 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2022

@jluhrsen: All pull requests linked via external trackers have merged:

Bugzilla bug 2084361 has been moved to the MODIFIED state.

In response to this:

Bug 2084361: Print error msg before os.Exit()

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@pweil- pweil- Awaiting requested review from pweil-

Assignees

@wking wking

@stbenjam stbenjam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jluhrsen @stbenjam @wking @openshift-ci-robot @openshift-merge-robot