Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cluster network MTU for bond interfaces #27631

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

kyrtapz
Copy link
Contributor

@kyrtapz kyrtapz commented Jan 4, 2023

The bond CNI test creates a macvlan interface that inherits its mtu from the hosts default gw nic.
Configure bond NAD config with mtu set to ClusterNetworkMTU which is not going to be higher than the hosts MTU.

Fixes https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-network-operator/1663/pull-ci-openshift-cluster-network-operator-release-4.12-e2e-network-mtu-migration-sdn-ipv4/1609870734950141952 where the host MTU is set to 1260.

/assign @mmirecki

Signed-off-by: Patryk Diak pdiak@redhat.com

The bond CNI test creates a macvlan interface that inherits its mtu from the hosts default gw nic.
Configure bond NAD config with mtu set to ClusterNetworkMTU which is not going to be higher than the hosts MTU.

Signed-off-by: Patryk Diak <pdiak@redhat.com>
@kyrtapz
Copy link
Contributor Author

kyrtapz commented Jan 5, 2023

/retest

@mmirecki
Copy link

mmirecki commented Jan 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2023

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-etcd-scaling 1a2cbe5 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-openstack-ovn 1a2cbe5 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-upgrade 1a2cbe5 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, mmirecki, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0c3302d into openshift:master Jan 5, 2023
@kyrtapz
Copy link
Contributor Author

kyrtapz commented Jan 9, 2023

/cherry-pick release-4.12

@openshift-cherrypick-robot

@kyrtapz: new pull request created: #27637

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@kyrtapz: new pull request could not be created: failed to create pull request against openshift/origin#release-4.12 from head openshift-cherrypick-robot:cherry-pick-27631-to-release-4.12: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-27631-to-release-4.12."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants