-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cluster network MTU for bond interfaces #27631
Conversation
The bond CNI test creates a macvlan interface that inherits its mtu from the hosts default gw nic. Configure bond NAD config with mtu set to ClusterNetworkMTU which is not going to be higher than the hosts MTU. Signed-off-by: Patryk Diak <pdiak@redhat.com>
/retest |
/lgtm |
@kyrtapz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyrtapz, mmirecki, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.12 |
@kyrtapz: new pull request created: #27637 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kyrtapz: new pull request could not be created: failed to create pull request against openshift/origin#release-4.12 from head openshift-cherrypick-robot:cherry-pick-27631-to-release-4.12: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-27631-to-release-4.12."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The bond CNI test creates a macvlan interface that inherits its mtu from the hosts default gw nic.
Configure bond NAD config with mtu set to ClusterNetworkMTU which is not going to be higher than the hosts MTU.
Fixes https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-network-operator/1663/pull-ci-openshift-cluster-network-operator-release-4.12-e2e-network-mtu-migration-sdn-ipv4/1609870734950141952 where the host MTU is set to 1260.
/assign @mmirecki
Signed-off-by: Patryk Diak pdiak@redhat.com