NE-1526: Re-introduce the DNS CI coverage for golang and glibc resolver libraries #27644

gcs278 · 2023-01-10T14:22:28Z

Cloned from #27135 so that I can take over the PR

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting 4a1e802.

Modifications to the previous reverted PR:

Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset.
A test for Go 1.16, 1.17, 1.18, and the latest GO version were added.
A check for baremetal environment was added to skip the test, as this environment is disconnected and does not have any suitable images on the local registry to use for different Go versions.
Converted dns_library_go.yaml to be a dynamic part of code
Added a build arg for the Dockerfile FROM base image, so that it could be dynamically populated
Reduced testdata directories go-v1-16 and go-v1-17 to be a single go-library-test directory. Now you can add a new GO version test just by adding to the GO Version Slice
Added latest as a test for the latest GO version so the test won't go stale.
Used e2e.RunHostCmd for simplifying some logic

…lver libraries"" This reverts commit 4a1e802. Modifications to the previous PR: Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset. A test for Go 1.16, 1.17, 1.18, and the latest GO version were added. A check for baremetal environment was added to skip the test, as this environment is disconnected and does not have any suitable images on the local registry to use for different Go versions.

openshift-ci-robot · 2023-01-18T22:54:16Z

@gcs278: This pull request references [Jira Issue NE-626](https://issues.redhat.com//browse/NE-626), which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-01-18T22:55:27Z

@gcs278: This pull request references [Jira Issue NE-626](https://issues.redhat.com//browse/NE-626), which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-01-18T22:56:13Z

@gcs278: This pull request references [Jira Issue NE-626](https://issues.redhat.com//browse/NE-626), which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-01-18T22:56:58Z

@gcs278: This pull request references [Jira Issue NE-626](https://issues.redhat.com//browse/NE-626), which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2023-01-25T17:05:00Z

test/extended/dns/dns_libraries.go

+
+		// 1.16 provides 404 error, though https://catalog.redhat.com/software/containers/rhel8/go-toolset/5b9c810add19c70b45cbd666?tag=1.16.12-10&push_date=1650995486000
+		// clearly states 1.16 is a tag
+		goVersions := []string{"1.16.12", "1.17", "1.18", "latest"}


Should we test latest? to keep updated?

candita · 2023-01-25T17:47:11Z

/assign @rfredette

gcs278 · 2023-01-30T19:38:08Z

/retest

jerpeter1 · 2023-03-21T15:43:52Z

/retest

gcs278 · 2023-03-22T14:46:46Z

@rfredette just a reminder for a review when the dust settles from 4.13 bugs.

gcs278 · 2023-06-07T21:00:01Z

@rfredette just a reminder for a review when the dust settles from 4.14 bugs.

rfredette · 2023-06-14T15:14:02Z

/retest

rfredette · 2023-06-14T16:13:35Z

/approve

@gcs278 I'm not sure why github isn't calling this out, but based on the retest results, it looks like this needs a rebase. Once it's been rebased, I'll lgtm this as well.

gcs278 · 2023-06-28T16:33:29Z

/hold
Thanks for the review @rfredette. Looking back at this PR after a long break, something feels awkward about this test. I'm going to put it on hold for now.

Essentially, we have a floating and always moving target version of GO, that we want to test. The code:

goVersions := []string{"1.16.12", "1.17", "1.18", "latest"}

Feels weird to me, because I know it's going to get outdated. Say in 3 years, we are now running with GO 1.27 because latest=GO 1.27. Well, the test is now skipping 1.19 - 1.26, but still testing 1.16 - 1.18. That feels awkward to me. I know no one is going to come back and update this code (that's how things go in software right?).

I wonder if it makes sense to test with just latest. The idea is that latest will allow us to gradually be fed the new versions of GO, but the assumption is that we don't need to continually test the previous versions. Still, it feels weird to me that we have an externally moving target (GO Version) that this test is at the mercy of.

openshift-bot · 2023-09-27T01:00:31Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2023-10-27T08:30:29Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2023-11-27T00:00:56Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2023-11-27T00:01:46Z

@openshift-bot: Closed this PR.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2024-02-28T15:47:22Z

We still want this test coverage.
/reopen
/remove-lifecycle rotten

openshift-ci-robot · 2024-02-28T15:55:06Z

@gcs278: This pull request references NE-626 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-02-28T15:55:25Z

@Miciah: Reopened this PR.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2024-02-28T16:04:21Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gcs278, rfredette
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

test/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2024-02-28T16:10:55Z

@gcs278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-etcd-scaling	`a7ab0d0`	link	false	`/test e2e-vsphere-ovn-etcd-scaling`
ci/prow/e2e-azure-ovn-etcd-scaling	`a7ab0d0`	link	false	`/test e2e-azure-ovn-etcd-scaling`
ci/prow/e2e-agnostic-ovn-cmd	`a7ab0d0`	link	false	`/test e2e-agnostic-ovn-cmd`
ci/prow/e2e-openstack-ovn	`a7ab0d0`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-gcp-ovn-rt-upgrade	`a7ab0d0`	link	false	`/test e2e-gcp-ovn-rt-upgrade`
ci/prow/e2e-aws-ovn-serial	`a7ab0d0`	link	true	`/test e2e-aws-ovn-serial`
ci/prow/e2e-aws-csi	`a7ab0d0`	link	false	`/test e2e-aws-csi`
ci/prow/e2e-aws-ovn-fips	`a7ab0d0`	link	true	`/test e2e-aws-ovn-fips`
ci/prow/e2e-metal-ipi-sdn	`a7ab0d0`	link	false	`/test e2e-metal-ipi-sdn`
ci/prow/e2e-metal-ipi-ovn-ipv6	`a7ab0d0`	link	true	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/images	`a7ab0d0`	link	true	`/test images`
ci/prow/e2e-gcp-ovn	`a7ab0d0`	link	true	`/test e2e-gcp-ovn`
ci/prow/unit	`a7ab0d0`	link	true	`/test unit`
ci/prow/e2e-aws-ovn-single-node-serial	`a7ab0d0`	link	false	`/test e2e-aws-ovn-single-node-serial`
ci/prow/verify-deps	`a7ab0d0`	link	true	`/test verify-deps`
ci/prow/e2e-aws-ovn-cgroupsv2	`a7ab0d0`	link	false	`/test e2e-aws-ovn-cgroupsv2`
ci/prow/e2e-gcp-ovn-builds	`a7ab0d0`	link	true	`/test e2e-gcp-ovn-builds`
ci/prow/e2e-aws-ovn-upgrade	`a7ab0d0`	link	false	`/test e2e-aws-ovn-upgrade`
ci/prow/e2e-aws-ovn-single-node-upgrade	`a7ab0d0`	link	false	`/test e2e-aws-ovn-single-node-upgrade`
ci/prow/e2e-gcp-csi	`a7ab0d0`	link	false	`/test e2e-gcp-csi`
ci/prow/e2e-aws-ovn-single-node	`a7ab0d0`	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/verify	`a7ab0d0`	link	true	`/test verify`
ci/prow/e2e-gcp-ovn-upgrade	`a7ab0d0`	link	true	`/test e2e-gcp-ovn-upgrade`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-02-29T19:22:06Z

@gcs278: This pull request references NE-1526 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-29T19:22:19Z

@gcs278: This pull request references NE-1526 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-29T19:22:23Z

@gcs278: This pull request references NE-1526 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci bot requested review from bparees and jwmatthews January 10, 2023 14:23

gcs278 mentioned this pull request Jan 10, 2023

NE-626: Re-introduce the DNS CI coverage for golang and glibc resolver libraries #27135

Closed

gcs278 force-pushed the stabilize branch from e4a55f7 to 04cd515 Compare January 18, 2023 22:31

gcs278 force-pushed the stabilize branch from 04cd515 to a7ab0d0 Compare January 18, 2023 22:43

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 18, 2023

gcs278 commented Jan 25, 2023

View reviewed changes

openshift-ci bot assigned rfredette Jan 25, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2023

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 27, 2023

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 27, 2023

openshift-ci bot closed this Nov 27, 2023

openshift-ci bot reopened this Feb 28, 2024

openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 28, 2024

gcs278 changed the title ~~NE-626: Re-introduce the DNS CI coverage for golang and glibc resolver libraries~~ NE-1526: Re-introduce the DNS CI coverage for golang and glibc resolver libraries Feb 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NE-1526: Re-introduce the DNS CI coverage for golang and glibc resolver libraries #27644

NE-1526: Re-introduce the DNS CI coverage for golang and glibc resolver libraries #27644

gcs278 commented Jan 10, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Jan 18, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Jan 18, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Jan 18, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Jan 18, 2023 •

edited by openshift-ci bot

gcs278 Jan 25, 2023

candita commented Jan 25, 2023

gcs278 commented Jan 30, 2023

jerpeter1 commented Mar 21, 2023

gcs278 commented Mar 22, 2023

gcs278 commented Jun 7, 2023

rfredette commented Jun 14, 2023

rfredette commented Jun 14, 2023

gcs278 commented Jun 28, 2023 •

edited

openshift-bot commented Sep 27, 2023

openshift-bot commented Oct 27, 2023

openshift-bot commented Nov 27, 2023

openshift-ci bot commented Nov 27, 2023

Miciah commented Feb 28, 2024

openshift-ci-robot commented Feb 28, 2024 •

edited by openshift-ci bot

openshift-ci bot commented Feb 28, 2024

openshift-ci bot commented Feb 28, 2024

openshift-ci bot commented Feb 28, 2024

openshift-ci-robot commented Feb 29, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 29, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 29, 2024 •

edited by openshift-ci bot

NE-1526: Re-introduce the DNS CI coverage for golang and glibc resolver libraries #27644

Are you sure you want to change the base?

NE-1526: Re-introduce the DNS CI coverage for golang and glibc resolver libraries #27644

Conversation

gcs278 commented Jan 10, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Jan 18, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Jan 18, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Jan 18, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Jan 18, 2023 • edited by openshift-ci bot

gcs278 Jan 25, 2023

Choose a reason for hiding this comment

candita commented Jan 25, 2023

gcs278 commented Jan 30, 2023

jerpeter1 commented Mar 21, 2023

gcs278 commented Mar 22, 2023

gcs278 commented Jun 7, 2023

rfredette commented Jun 14, 2023

rfredette commented Jun 14, 2023

gcs278 commented Jun 28, 2023 • edited

openshift-bot commented Sep 27, 2023

openshift-bot commented Oct 27, 2023

openshift-bot commented Nov 27, 2023

openshift-ci bot commented Nov 27, 2023

Miciah commented Feb 28, 2024

openshift-ci-robot commented Feb 28, 2024 • edited by openshift-ci bot

openshift-ci bot commented Feb 28, 2024

openshift-ci bot commented Feb 28, 2024

openshift-ci bot commented Feb 28, 2024

openshift-ci-robot commented Feb 29, 2024 • edited by openshift-ci bot

openshift-ci-robot commented Feb 29, 2024 • edited by openshift-ci bot

openshift-ci-robot commented Feb 29, 2024 • edited by openshift-ci bot

gcs278 commented Jan 10, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Jan 18, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Jan 18, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Jan 18, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Jan 18, 2023 •

edited by openshift-ci bot

gcs278 commented Jun 28, 2023 •

edited

openshift-ci-robot commented Feb 28, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 29, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 29, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 29, 2024 •

edited by openshift-ci bot