Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-13840: Add missing error check in sysctl allowlist test #27929

Merged
merged 1 commit into from
May 26, 2023
Merged

[release-4.13] OCPBUGS-13840: Add missing error check in sysctl allowlist test #27929

merged 1 commit into from
May 26, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #27914

/assign mlguerrero12

@mlguerrero12
OCPBUGS-13372: Add missing error check in sysctl allowlist test
e21cc2f 
This prevents the test to pass when the pod is not running.
A bug was not detected due to this missing check.

Signed-off-by: Marcelo Guerrero Viveros <marguerr@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 19, 2023
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-13372 has been cloned as Jira Issue OCPBUGS-13840. Will retitle bug to link to clone.
/retitle [release-4.13] OCPBUGS-13840: Add missing error check in sysctl allowlist test

In response to this:

This is an automated cherry-pick of #27914

/assign mlguerrero12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-13372: Add missing error check in sysctl allowlist test [release-4.13] OCPBUGS-13840: Add missing error check in sysctl allowlist test May 19, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 19, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-13840, which is invalid:

  • expected dependent Jira Issue OCPBUGS-13372 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #27914

/assign mlguerrero12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.13] OCPBUGS-13840: Add missing error check in sysctl allowlist test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from danwinship and trozet May 19, 2023 09:08
@mlguerrero12
Copy link
Member

/retest

@danwinship
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023
@mlguerrero12
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 22, 2023
@openshift-ci-robot
Copy link

@mlguerrero12: This pull request references Jira Issue OCPBUGS-13840, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-13372 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-13372 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mlguerrero12
Copy link
Member

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023 •
edited

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade e21cc2f link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-agnostic-ovn-cmd e21cc2f link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mlguerrero12
Copy link
Member

/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

@mlguerrero12: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mlguerrero12
Copy link
Member

@bparees @deads2k, could you please help me with the missing labels? (backport-risk-assesed)

@bparees
Copy link
Contributor

bparees commented May 26, 2023

/label backport-risk-assessed

let's see if we ever got this permission working.....

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 26, 2023
@bparees
Copy link
Contributor

bparees commented May 26, 2023

i'm also going to mark this cherry pick approved as there is nothing for QE to do here.

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 26, 2023
@mlguerrero12
Copy link
Member

thank you

@mlguerrero12
Copy link
Member

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 3a41eb3 into openshift:release-4.13 May 26, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-13840: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13840 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #27914

/assign mlguerrero12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shellyyang1989 shellyyang1989 mentioned this pull request Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@trozet trozet Awaiting requested review from trozet

Assignees

@dgoodwin dgoodwin

@danwinship danwinship

@stbenjam stbenjam

@kasturinarra kasturinarra

@jadhaj jadhaj

@mlguerrero12 mlguerrero12

@pamoedom pamoedom

@jitendar-singh jitendar-singh

@prietyc123 prietyc123

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet