Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make oc status output describeable #3687

Merged
merged 1 commit into from Jul 21, 2015

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jul 13, 2015

Updates oc status output to make it possible to copy and paste names directly into oc describe. This way, if a new user wants more details, oc describe arguments can be directly copied and pasted.

It also makes the connections between different types very clear to advanced users. "Is this a bc, dc, or is?" will never be an issue.

In project foo

service/ruby-hello-world - 172.30.1.102:8080
  dc/ruby-hello-world deploys istag/ruby-hello-world:latest <-
    docker build of https://github.com/openshift/ruby-hello-world through bc/ruby-hello-world 
      build 1 failed 2 days ago (can't push to image)
    #1 deployment waiting on image or update

Warning: Some of your builds are pointing to image streams, but the administrator has not configured the integrated Docker registry (oadm registry).
To see more, use 'oc describe <resource>/<name>'.
You can use 'oc get all' to see a list of other objects.

@deads2k
Copy link
Contributor Author

deads2k commented Jul 13, 2015

@smarterclayton opinions?

@smarterclayton
Copy link
Contributor

adding the bc name is kind of ugly.

@deads2k
Copy link
Contributor Author

deads2k commented Jul 13, 2015

adding the bc name is kind of ugly.

If you looked at oc status before and said to yourself, "that looks wrong", how would you have known where to look before?

@smarterclayton
Copy link
Contributor

Yeah, but if I saw something ugly I probably wouldn't know it other. When
I say "ugly" I usually mean "non-obvious" or "hard to understand". Also,
in all the cases where the name is redundant, it wastes valuable columns on
a very long line (where the image value is more important). It's possible
that this just needs to be broken into its own line - "built by
bc/hello-world-sample" or similar

On Mon, Jul 13, 2015 at 2:39 PM, David Eads notifications@github.com
wrote:

adding the bc name is kind of ugly.

If you looked at oc status before and said to yourself, "that looks
wrong", how would you have known where to look before?


Reply to this email directly or view it on GitHub
#3687 (comment).

Clayton Coleman | Lead Engineer, OpenShift

@deads2k
Copy link
Contributor Author

deads2k commented Jul 14, 2015

Updated example with "built by " line. I think a lot of the uglyness is from the wrapping of the image source line, but at 120 characters that's going to happen pretty often.

Tangentially related: should we warn if two BCs push to the same ISTag?

@deads2k
Copy link
Contributor Author

deads2k commented Jul 15, 2015

Is it still ugly? If so, would removing the built-by line be sufficient? What I put the bc at the end of the build line build 1 new for 6 minutes (can't push to image) bc/ruby-hello-world?

@smarterclayton
Copy link
Contributor

How about:

In project foo

service/ruby-hello-world - 172.30.168.251:8080
  dc/ruby-hello-world deploys istag/ruby-hello-world:latest
    docker build of https://github.com/openshift/ruby-hello-world through bc/ruby-hello-world
      build 1 new for 6 minutes (can't push to image)
    #1 deployment waiting on image or update

Warning: Some of your builds are pointing to image streams, but the administrator has not configured the integrated Docker registry (oadm registry).
To see more, use 'oc describe <resource>/<name>'.
You can use 'oc get all' to see a list of other objects.

@smarterclayton
Copy link
Contributor

I'm not totally in love with that, but it does reduce the number of extra lines

@deads2k deads2k force-pushed the status-make-copiable branch 3 times, most recently from 56a454e to 2895028 Compare July 20, 2015 14:31
@deads2k
Copy link
Contributor Author

deads2k commented Jul 20, 2015

I'm not totally in love with that, but it does reduce the number of extra lines

Updated code and description to match your previous comment.

@smarterclayton
Copy link
Contributor

LGTM [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/2799/) (Image: devenv-fedora_2039)

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/3695/)

@deads2k
Copy link
Contributor Author

deads2k commented Jul 21, 2015

data race flake that was fixed [merge]

@deads2k deads2k force-pushed the status-make-copiable branch 2 times, most recently from ea68537 to 7cdc994 Compare July 21, 2015 18:42
@openshift-bot
Copy link
Contributor

Evaluated for origin up to 7cdc994

openshift-bot pushed a commit that referenced this pull request Jul 21, 2015
@openshift-bot openshift-bot merged commit 00d54b4 into openshift:master Jul 21, 2015
@deads2k deads2k deleted the status-make-copiable branch July 31, 2015 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants