Bug 1268891 - pods not always grouped when service selector should cover template of a dc/deployment #5210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liggitt would like you to look at this one |
| @@ -227,7 +227,7 @@ angular.module('openshiftConsole') | |||
| $scope.deploymentConfigsByService = {"": {}}; | |||
| angular.forEach($scope.deploymentConfigs, function(deploymentConfig, depName){ | |||
| var foundMatch = false; | |||
| var depConfigSelector = new LabelSelector(deploymentConfig.spec.selector); | |||
| var depConfigSelector = new LabelSelector(deploymentConfig.spec.template.metadata.labels); | |||
|
nit, then LGTM |
…ver template of a dc/deployment
jwforres
force-pushed
the
bug_1268891_ungrouped_pods_in_overview
branch
from
8383d1f
to
2944083
Compare
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5953/) (Image: devenv-rhel7_2497) |
|
Evaluated for origin merge up to 2944083 |
|
[Test]ing while waiting on the merge queue |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5953/) |
|
Evaluated for origin test up to 2944083 |
openshift-bot
pushed a commit
that referenced
this pull request
Oct 20, 2015
…overview Merged by openshift-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.