Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1268891 - pods not always grouped when service selector should cover template of a dc/deployment #5210

Conversation

jwforres
Copy link
Member

No description provided.

@jwforres
Copy link
Member Author

@liggitt would like you to look at this one

@@ -227,7 +227,7 @@ angular.module('openshiftConsole')
$scope.deploymentConfigsByService = {"": {}};
angular.forEach($scope.deploymentConfigs, function(deploymentConfig, depName){
var foundMatch = false;
var depConfigSelector = new LabelSelector(deploymentConfig.spec.selector);
var depConfigSelector = new LabelSelector(deploymentConfig.spec.template.metadata.labels);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guard

@liggitt
Copy link
Contributor

liggitt commented Oct 19, 2015

nit, then LGTM

@jwforres jwforres force-pushed the bug_1268891_ungrouped_pods_in_overview branch from 8383d1f to 2944083 Compare October 19, 2015 20:42
@jwforres
Copy link
Member Author

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5953/) (Image: devenv-rhel7_2497)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 2944083

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5953/)

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 2944083

openshift-bot pushed a commit that referenced this pull request Oct 20, 2015
@openshift-bot openshift-bot merged commit 24ce20a into openshift:master Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants