New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display info about what new-app is doing #5476
Display info about what new-app is doing #5476
Conversation
[test] |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6362/) |
d88f2e6
to
0509daa
Compare
@@ -220,7 +220,7 @@ function tryuntil { | |||
timeout=$(($(date +%s) + 90)) | |||
echo "++ Retrying until success or timeout: ${@}" | |||
while [ 1 ]; do | |||
if eval "${@}" 2>&1 >/dev/null; then | |||
if eval "${@}" >/dev/null 2>&1; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
humph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Bash is AWESOME!!!!!1111!!11!!1!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like &> /dev/null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
me too but i think that's considered deprecated syntax: http://wiki.bash-hackers.org/scripting/obsolete
i'm liking the examples, will review the code in the morning. |
1ec450e
to
a931513
Compare
a931513
to
7708596
Compare
Comments on the examples:
maybe
|
We should output in the create order... if we change anything, it should be the order we create in, though I assume it is the way it currently is for a reason |
Yes, we generate and sort to get certain offerings. On Oct 29, 2015, at 8:30 AM, Jordan Liggitt notifications@github.com Is it possible to organize the list of resources being created by their We should output in the create order... if we change anything, it should be — |
7708596
to
93f4af3
Compare
[merge] will address other comments after i cut 1.0.7 |
Evaluated for origin test up to 93f4af3 |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6362/) (Image: devenv-rhel7_2592) |
Evaluated for origin merge up to 93f4af3 |
Merged by openshift-bot
Changes Unknown when pulling 93f4af3 on smarterclayton:display_info_on_new_app into ** on openshift:master**. |
@bparees @csrwng @jwforres for review
Examples: