New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 17886: pod log location must validate container if provided #6113
Conversation
|
Upstream PR: kubernetes/kubernetes#17886 @ncdc not sure if it's you, but ptal (here and upstream). |
| @@ -235,6 +235,7 @@ func LogLocation(getter ResourceGetter, connInfo client.ConnectionInfoGetter, ct | |||
| } | |||
|
|
|||
| // Try to figure out a container | |||
| // If a container were provided, it must be valid | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/were/was/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
3f707bc
to
4356c0b
Compare
|
[test] |
8ee8552
to
61d00fb
Compare
|
61d00fb
to
867bda5
Compare
|
@liggitt Seems just the mock, since we are now using the actual name from the rest api object, the mocks have to honour it. Fixed, let's see how it goes. |
|
Yup, split origin changes into their own commit |
|
@liggitt of course, missed that. |
867bda5
to
9158aa1
Compare
|
Evaluated for origin test up to 9158aa1 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7527/) |
|
I will cut 1.1.0.1 with this once merged. |
|
Lgtm, [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4177/) (Image: devenv-rhel7_2827) |
|
Evaluated for origin merge up to 9158aa1 |
Merged by openshift-bot
@smarterclayton This still happening? |
|
Should also pick up #6129 |
|
Once Jordan tells me to On Dec 1, 2015, at 10:50 AM, Jordan Liggitt notifications@github.com Should also pick up #6129 #6129 — |
|
@smarterclayton go ahead (either from master or from ba7f510) |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1286094