New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide old deployments in the topology view #6130
Conversation
$scope.isVisibleDeployment = function(deployment) { | ||
// If this is a replication controller and not a deployment, then it's visible. | ||
var dcName = annotationFilter(deployment, 'deploymentConfig'); | ||
if (!dcName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to do if ( !$filter('isDeployment', deployment) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only reason is to avoid resolving the filter inside a loop.
just the one question, otherwise LGTM |
OK. [merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4203/) (Image: devenv-rhel7_2849) |
Evaluated for origin merge up to ef214a6 |
[Test]ing while waiting on the merge queue |
[test] |
Evaluated for origin test up to ef214a6 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7581/) |
Fixes #5091
/cc @jwforres @stefwalter