Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make KUBE_TIMEOUT take a duration #6436

Merged
merged 1 commit into from Dec 23, 2015

Conversation

rhcarvalho
Copy link
Contributor

To use a different timeout, use:

$ KUBE_TIMEOUT=2m ./hack/test-go.sh ...

@smarterclayton
Copy link
Contributor

smarterclayton commented Dec 21, 2015 via email

To use a different timeout, use:

$ KUBE_TIMEOUT=2m ./hack/test-go.sh
@rhcarvalho rhcarvalho changed the title Surround default timeout with quotes Make KUBE_TIMEOUT take a duration Dec 22, 2015
@rhcarvalho
Copy link
Contributor Author

Updated description, original was:

Make it explicit that it is "-timeout" and not "--timeout".

BTW why don't we make KUBE_TIMEOUT be just a duration, so that one don't need to write "-timeout" when overriding the default?

@rhcarvalho
Copy link
Contributor Author

@smarterclayton @danmcp PTAL

@smarterclayton
Copy link
Contributor

LGTM [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4476/) (Image: devenv-rhel7_3033)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 8fc9c9e

openshift-bot pushed a commit that referenced this pull request Dec 23, 2015
@openshift-bot openshift-bot merged commit b197d32 into openshift:master Dec 23, 2015
@rhcarvalho rhcarvalho deleted the explicit-timeout branch December 23, 2015 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants