remove test file cruft

[stevekuznetsov]

@smarterclayton the changes in test/cmd/admin remove your previous comments

@fabianofranz the changes in test/cmd/help get rid of tests for openshift cli help which looks to have been deprecated?

[smarterclayton]

Hrm - that todo for test/cmd/help implies the tests should be fixed, not removed.

The manage-node stuff needs to be moved to extended. Can you create an issue and paste them in as "need unit tests for manage-node"?

[stevekuznetsov]

@smarterclayton issue for manage-node here: #7997

[stevekuznetsov]

@fabianofranz re: openshift cli help - the intent here is to have a test that ensures that openshift cli help (and oc help?) are wired up and working, right? we aren't explicitly trying to test the help output of any command, are we? Would one call to openshift cli help suffice?

[fabianofranz]

@stevekuznetsov Right, help being wired up and spitting the output expected for it (e.g. we get the help for the expected command instead of main help). Not testing any particular command though, no.

So I agree we don't need all of them, this could be reduced to just a couple tests - one call to openshift cli help and one to one of those commands, whatever it is, checking part of the output.

Related issue is #6042.

[stevekuznetsov]

Oh, I had created an issue when I removed those tests. OK. If an issue exists to fix both of these commented-out test cases, we should be good to remove the lines for now, right?

[stevekuznetsov]

@smarterclayton would like your opinion - if issues (#6042 and #7997) exist for both of these cases, is this ready to merge?

[smarterclayton]

Yes

[stevekuznetsov]

@smarterclayton could you please then slap a merge tag on this

[smarterclayton]

[merge]

[openshift-bot]

Evaluated for origin merge up to a18cfc9

[openshift-bot]

[Test]ing while waiting on the merge queue

[openshift-bot]

Evaluated for origin test up to a18cfc9

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2587/)

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2587/) (Image: devenv-rhel7_3871)

[stevekuznetsov]

Jenkins flaked on UI e2e breadcrumb here:

**************************************************
*                    Failures                    *
**************************************************

1)  authenticated e2e-user new project when creating a new project should successfully create a new project
  - Error: Element not found: .breadcrumb li a

#6618
@smarterclayton please re-tag for merge