Adjust -webkit-scrollbar width and log-scroll-top affixed position. #8133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spadgett PTAL |
|
Will this work on all platforms? I suspect the scrollbar is a different width in Firefox on OS X vs Linux for instance. How does it look on IE? We might calculate the scrollbar width in JavaScript, which is possible. |
|
/cc @jwforres |
|
Linux firefox with this fix applied:
|
|
I'm OK with the change. @sg00dwin you tested IE, right? |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5387/) (Image: devenv-rhel7_3792) |
|
Evaluated for origin merge up to 3bafec6 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 3bafec6 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2359/) |
openshift-bot
pushed a commit
that referenced
this pull request
Mar 21, 2016
Merged by openshift-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7963
The variance between scrollbar widths is the culprit, thus position:fixed distance to viewport right edge is different. These changes make the widths of the scrollbars, mostly consistent.
chrome
