force pull fixes / debug #8562
force pull fixes / debug #8562
Conversation
|
lgtm but i see the test failed, do you want to investigate that further before this gets merged? |
|
Similar to another PR I just attempted an extended test on, this extended test failed with a vagrant / AWS hiccup: not enough capacity in the US east zone, prior to the extended test running. That said, I'd still like to see a pre-merge run with the changes in the PR. |
| @@ -30,6 +30,21 @@ func ResetImage(tags map[string]string) { | |||
|
|
|||
| } | |||
|
|
|||
| //DumpImage is a helper that inspects the image along with some ginkgo debug | |||
| func DumpImage(name string) { | |||
| g.By(fmt.Sprintf("Calling docker inspect for image %s", name)) | |||
There was a problem hiding this comment.
I would think that e2e.Logf would be more appropriate here.
g.By is used to describe test cases
There was a problem hiding this comment.
or directly fmt.Fprintf() to g.GinkgoWriter
There was a problem hiding this comment.
went with the latter (even got some nice blue highlighting in emacs with it :-) ) ... thanks - will push in a moment
gabemontero
force-pushed
the
fixFPExtTest
branch
from
d4efa7f
to
beba7a1
Compare
|
Somehow "forcePull" got converted to "forcepull" and the extended test failed with not being able to find the custom focus....I'll see if I can find some sort of logic like that in the vagrant plugin. |
|
[testonlyextended][extended:core(builds)] |
|
@bparees - i ran the full builds suite given the forcepull/forcePull conundrum (I decided not the change the "forcePull" string in the Describe to "forcepull" at this time), and the forcePull test passed. Please hit the merge button unless you've had a change of opinion from earlier. |
|
the other g.By() invocations should probably be converted as well. |
gabemontero
force-pushed
the
fixFPExtTest
branch
from
beba7a1
to
a39d507
Compare
|
other newly added g.By() invocations converted and pushed |
|
[testonlyextended][extended:core(builds)] |
|
Evaluated for origin testonlyextended up to a39d507 |
|
lgtm but needs secondary merge approval. @smarterclayton this only affects extended tests, no product code. |
|
continuous-integration/openshift-jenkins/testonlyextended FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/72/) (Extended Tests: core(builds)) |
|
Approved On Apr 19, 2016, at 10:30 PM, Ben Parees notifications@github.com wrote: lgtm but needs secondary merge approval. @smarterclayton — |
|
[merge] Ben Parees | OpenShift
|
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5646/) (Image: devenv-rhel7_4003) |
|
[merge] |
|
Evaluated for origin merge up to a39d507 |
@bparees @csrwng PTAL ...