Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use "kexec" as both a package name and a variable name #9771

Merged
merged 1 commit into from Aug 1, 2016

Conversation

danwinship
Copy link
Contributor

leftover nit from #9520, requested by @liggitt

(we were previously using os/exec in a few places as well, but the interface returned by kexec.New() has the same API as os/exec, so renaming that variable to "exec" makes the os/exec import unnecessary/conflicting)

(Also, get rid of some uses of os/exec in places where we're also
using kexec.)
@danwinship
Copy link
Contributor Author

@openshift/networking can someone take a look? easy fix

@pravisankar
Copy link

LGTM

@pravisankar
Copy link

[merge]

@pravisankar
Copy link

re[merge]

@dcbw
Copy link
Member

dcbw commented Jul 30, 2016

Seems like a transient error... error: running '/bin/sh -c curl -L -o /etc/yum.repos.d/origin-next-epel-7.repo https://copr.fedoraproject.org/coprs/maxamillion/origin-next/repo/epel-7/maxamillion-origin-next-epel-7.repo && INSTALL_PKGS="openvswitch" && yum install -y $INSTALL_PKGS && rpm -V $INSTALL_PKGS && yum clean all && chmod +x /usr/local/bin/*' failed with exit code 1

re[merge]

@danwinship
Copy link
Contributor Author

@stevekuznetsov
Copy link
Contributor

re[merge]

@dcbw
Copy link
Member

dcbw commented Aug 1, 2016

Failure was:

  • vagrant ssh -c 'sudo journalctl --no-pager --all --lines=10000 --unit=docker'
    /tmp/hudson3790246935591707680.sh: line 3: origin/artifacts/docker.journal: No such file or directory

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 1, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7306/) (Image: devenv-rhel7_4715)

@stevekuznetsov
Copy link
Contributor

re[merge] -- that was a bad Jenkins job config

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to a50b49b

@openshift-bot openshift-bot merged commit c008a82 into openshift:master Aug 1, 2016
@danwinship danwinship deleted the fix-sdn-merge-nit branch August 2, 2016 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants