Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run all parallel builds when a serial build finishes #9969

Merged
merged 1 commit into from Jul 21, 2016

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Jul 20, 2016

@bparees
Copy link
Contributor Author

bparees commented Jul 20, 2016

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 583033a

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6637/)


func TestHandleCompleteParallel(t *testing.T) {
builds := []buildapi.Build{
addBuild("build-1", "sample-bc", buildapi.BuildPhaseComplete, buildapi.BuildRunPolicyParallel),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be serial?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't really matter, the point is to ensure that when a build completes, we immediately start all queued parallel builds. the code path is the same regardless of what type of build completed.

but for sanity, i'll change it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually i think i'm going to leave it since it's TestHandleCompleteParallel.

@bparees
Copy link
Contributor Author

bparees commented Jul 21, 2016

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 21, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6637/) (Image: devenv-rhel7_4640)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 583033a

@openshift-bot openshift-bot merged commit 6fb5bf6 into openshift:master Jul 21, 2016
@bparees bparees deleted the build_parallel branch July 24, 2016 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants