Avoid deepcopying unconditionally #9970
Conversation
|
[test] |
| c.emitDeploymentEvent(deployment, kapi.EventTypeWarning, "Failed", fmt.Sprintf("Deployer pod %q has gone missing", deployerPodName)) | ||
| glog.V(4).Infof("Failing deployment %q because its deployer pod %q disappeared", deployutil.LabelForDeployment(deployment), deployerPodName) | ||
| glog.V(2).Infof("Failing deployment %q because its deployer pod %q disappeared", deployutil.LabelForDeployment(deployment), deployerPodName) |
There was a problem hiding this comment.
Not sure why these were changed
There was a problem hiding this comment.
INFO: >=4
WARN: >=2
ERR: >= 0
There was a problem hiding this comment.
Controller failures should be v4 if they will happen in normal use. V2 is
for "we did not expect this to happen".
On Jul 21, 2016, at 2:45 AM, Michail Kargakis notifications@github.com
wrote:
In pkg/deploy/controller/deployment/controller.go
#9970 (comment):
c.emitDeploymentEvent(deployment, kapi.EventTypeWarning, "Failed", fmt.Sprintf("Deployer pod %q has gone missing", deployerPodName))
glog.V(4).Infof("Failing deployment %q because its deployer pod %q disappeared", deployutil.LabelForDeployment(deployment), deployerPodName)glog.V(2).Infof("Failing deployment %q because its deployer pod %q disappeared", deployutil.LabelForDeployment(deployment), deployerPodName)
INFO: >=4
WARN: >=2
ERR: >= 0
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/openshift/origin/pull/9970/files/243f2894ba329617dab910eacd4c935f5ba9d49f#r71654205,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p0eY9tv2cBnDIyLxHIPrkKFej3gAks5qXxWggaJpZM4JRTaV
.
There was a problem hiding this comment.
A deployer pod that just disappeared isn't normal (except if we deleted it but the log is not for that case)
There was a problem hiding this comment.
|
[test] conformance runs forever On Sun, Jul 24, 2016 at 5:05 PM, OpenShift Bot notifications@github.com
|
|
[test] |
|
Evaluated for origin test up to 8be964b |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7438/) |
|
LGTM |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7446/) (Image: devenv-rhel7_4742) |
|
Evaluated for origin merge up to 8be964b |
Fixes #9860
@mfojtik @deads2k