Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2060586: [4.10.0] [RFE] use /dev/ptp_hyperv on Azure/AzureStack #742

Merged
merged 1 commit into from Mar 11, 2022

Conversation

aaradhak
Copy link
Contributor

@aaradhak aaradhak commented Mar 8, 2022

Bump fedora-coreos-config submodule

'''
git shortlog --no-merges 7625231a33ffce40e0dbe3f26132e4babda3ab66..
François Rigault (1):
chrony: use /dev/ptp_hyperv on AzureStack
'''

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2022
@aaradhak aaradhak changed the base branch from master to release-4.10 March 8, 2022 16:28
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 8, 2022

@aaradhak: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Update FCOS - chrony: use /dev/ptp_hyperv on AzureStack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jlebon and peberanek March 8, 2022 16:29
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2022
@miabbott
Copy link
Member

miabbott commented Mar 8, 2022

Please title this PR to reference BZ 2060586

And please add the output of git shortlog --no-merges for the f-c-c bump as part of the commit message/first comment

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2022
Bump fedora-coreos-config submodule

'''
git shortlog --no-merges 7625231a33ffce40e0dbe3f26132e4babda3ab66..
François Rigault (1):
      chrony: use /dev/ptp_hyperv on AzureStack
'''
@aaradhak
Copy link
Contributor Author

Please title this PR to reference BZ 2060586

And please add the output of git shortlog --no-merges for the f-c-c bump as part of the commit message/first comment

I have added the BZ title and the git shortlog output.

@miabbott
Copy link
Member

Please title this PR to reference BZ 2060586
And please add the output of git shortlog --no-merges for the f-c-c bump as part of the commit message/first comment

I have added the BZ title and the git shortlog output.

You have to update the title of the PR here on GitHub too

Also, please update the first comment here on GitHub to show the shortlog

@aaradhak aaradhak changed the title Update FCOS - chrony: use /dev/ptp_hyperv on AzureStack Bug 2060586 : [4.10.z] [RFE] use /dev/ptp_hyperv on Azure/AzureStack Mar 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

@aaradhak: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug 2060586 : [4.10.z] [RFE] use /dev/ptp_hyperv on Azure/AzureStack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aaradhak aaradhak changed the title Bug 2060586 : [4.10.z] [RFE] use /dev/ptp_hyperv on Azure/AzureStack Bug 2060586 - [4.10.z] [RFE] use /dev/ptp_hyperv on Azure/AzureStack Mar 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

@aaradhak: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug 2060586 - [4.10.z] [RFE] use /dev/ptp_hyperv on Azure/AzureStack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aaradhak aaradhak changed the title Bug 2060586 - [4.10.z] [RFE] use /dev/ptp_hyperv on Azure/AzureStack Bug 2060586: [4.10.z] [RFE] use /dev/ptp_hyperv on Azure/AzureStack Mar 10, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

@aaradhak: This pull request references Bugzilla bug 2060586, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "4.10.z" instead
  • expected dependent Bugzilla bug 2037841 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2060586: [4.10.z] [RFE] use /dev/ptp_hyperv on Azure/AzureStack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aaradhak aaradhak changed the title Bug 2060586: [4.10.z] [RFE] use /dev/ptp_hyperv on Azure/AzureStack Bug 2060586: [4.10.0] [RFE] use /dev/ptp_hyperv on Azure/AzureStack Mar 10, 2022
@miabbott
Copy link
Member

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

@miabbott: This pull request references Bugzilla bug 2060586, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "4.10.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

@aaradhak: This pull request references Bugzilla bug 2060586, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "4.10.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2060586: [4.10.0] [RFE] use /dev/ptp_hyperv on Azure/AzureStack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott
Copy link
Member

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

@aaradhak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mike-nguyen
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaradhak, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aaradhak,mike-nguyen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2022

@openshift-bot: This pull request references Bugzilla bug 2060586, which is invalid:

  • expected dependent Bugzilla bug 2037841 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aaradhak
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2022

@aaradhak: This pull request references Bugzilla bug 2060586, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.z) matches configured target release for branch (4.10.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2037841 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2037841 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 11, 2022
@openshift-ci openshift-ci bot requested a review from mike-nguyen March 11, 2022 19:39
@openshift-merge-robot openshift-merge-robot merged commit 3bdb871 into openshift:release-4.10 Mar 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2022

@aaradhak: All pull requests linked via external trackers have merged:

Bugzilla bug 2060586 has been moved to the MODIFIED state.

In response to this:

Bug 2060586: [4.10.0] [RFE] use /dev/ptp_hyperv on Azure/AzureStack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants