overlay/rhcos-fde: Drop cryptsetup-reencrypt
#788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer use this since 2fba76e The current LUKS code in this repository is only for the legacy use case of unlocking an old-style volume before Ignition had native LUKS. We don't need `cryptsetup-reencrypt` which is not part of RHEL9 right now.
openshift-ci
bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, miabbott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cgwalters: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
miabbott
added a commit
to miabbott/os
that referenced
this pull request
Jun 14, 2022
The use of `cryptsetup-reencrypt` goes back to the null-cipher LUKS container that we used to do disk encryption in early, early OCP 4 days. As part of openshift#788, the `rhcos-fde` dracut module dropped the requirement on this package, so we should be able to safely drop it from the manifest as well.
miabbott
added a commit
to miabbott/os
that referenced
this pull request
Jun 14, 2022
The use of `cryptsetup-reencrypt` goes back to the null-cipher LUKS container that we used to do disk encryption in early, early OCP 4 days. As part of openshift#788, the `rhcos-fde` dracut module dropped the requirement on this package, so we should be able to safely drop it from the manifest as well.
miabbott
added a commit
to travier/os
that referenced
this pull request
Jun 15, 2022
The use of `cryptsetup-reencrypt` goes back to the null-cipher LUKS container that we used to do disk encryption in early, early OCP 4 days. As part of openshift#788, the `rhcos-fde` dracut module dropped the requirement on this package, so we should be able to safely drop it from the manifest as well.
travier
pushed a commit
to travier/os
that referenced
this pull request
Jun 17, 2022
The use of `cryptsetup-reencrypt` goes back to the null-cipher LUKS container that we used to do disk encryption in early, early OCP 4 days. As part of [1], the `rhcos-fde` dracut module dropped the requirement on this package, so we should be able to safely drop it from the manifest as well. [1] openshift#788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer use this since 2fba76e
The current LUKS code in this repository is only for the legacy use
case of unlocking an old-style volume before Ignition had native
LUKS.
We don't need
cryptsetup-reencryptwhich is not part of RHEL9right now.