New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2094777: manifest: pull conmon pkg from RHAOS repo for 4.10 #830
Bug 2094777: manifest: pull conmon pkg from RHAOS repo for 4.10 #830
Conversation
|
@HuijingHei: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one nit
This allows us to land OCP specific changes to conmon and potentially ship newer versions than what would available in the module.
|
/retest |
|
This needs a manual backport of #814. I'm working on it. |
|
/retitle Bugzilla 2094777: manifest: pull conmon pkg from RHAOS repo |
|
@HuijingHei: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retitle Bug 2094777: manifest: pull conmon pkg from RHAOS repo |
|
@HuijingHei: This pull request references Bugzilla bug 2094777, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@travier: This pull request references Bugzilla bug 2094777, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@travier: This pull request references Bugzilla bug 2094777, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
In
I'll see if I can trigger a new build of |
|
/retitle Bug 2094777: manifest: pull conmon pkg from RHAOS repo for 4.10 |
|
Not sure we should block on getting our full CI working for this, we only barely cover conmon via basic podman/crio testing, and those passed. |
Agreed. /override ci/prow/build-test-qemu /meow |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
FYI, all |
|
@miabbott: Overrode contexts on behalf of miabbott: ci/prow/build-test-qemu, ci/prow/validate In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuijingHei, jmarrero, mike-nguyen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@HuijingHei: All pull requests linked via external trackers have merged: Bugzilla bug 2094777 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@HuijingHei: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |

This allows us to land OCP specific changes to conmon and
potentially ship newer versions than what would available in the module.