Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2094777: manifest: pull conmon pkg from RHAOS repo for 4.10 #830

Merged

Conversation

HuijingHei
Copy link
Contributor

This allows us to land OCP specific changes to conmon and
potentially ship newer versions than what would available in the module.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@HuijingHei: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

manifest: pull conmon pkg from RHAOS repo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dustymabe and jmarrero June 8, 2022 05:38
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@HuijingHei
Copy link
Contributor Author

/retest

manifest.yaml Outdated Show resolved Hide resolved
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit

This allows us to land OCP specific changes to conmon and
potentially ship newer versions than what would available in the module.
@joepvd
Copy link

joepvd commented Jun 8, 2022

/retest

@travier
Copy link
Member

travier commented Jun 8, 2022

This needs a manual backport of #814. I'm working on it.

@travier
Copy link
Member

travier commented Jun 8, 2022

#831

@travier
Copy link
Member

travier commented Jun 8, 2022

/retitle Bugzilla 2094777: manifest: pull conmon pkg from RHAOS repo

@openshift-ci openshift-ci bot changed the title manifest: pull conmon pkg from RHAOS repo Bugzilla 2094777: manifest: pull conmon pkg from RHAOS repo Jun 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@HuijingHei: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bugzilla 2094777: manifest: pull conmon pkg from RHAOS repo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Member

travier commented Jun 8, 2022

/retitle Bug 2094777: manifest: pull conmon pkg from RHAOS repo

@openshift-ci openshift-ci bot changed the title Bugzilla 2094777: manifest: pull conmon pkg from RHAOS repo Bug 2094777: manifest: pull conmon pkg from RHAOS repo Jun 8, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@HuijingHei: This pull request references Bugzilla bug 2094777, which is invalid:

  • expected Bugzilla bug 2094777 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2094777: manifest: pull conmon pkg from RHAOS repo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Member

travier commented Jun 8, 2022

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@travier: This pull request references Bugzilla bug 2094777, which is invalid:

  • expected dependent Bugzilla bug 2094041 to target a release in 4.11.0, but it targets "4.10.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Member

travier commented Jun 8, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@travier: This pull request references Bugzilla bug 2094777, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.z) matches configured target release for branch (4.10.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2094781 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2094781 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from mike-nguyen June 8, 2022 09:50
@mike-nguyen
Copy link
Member

/lgtm

@miabbott
Copy link
Member

miabbott commented Jun 8, 2022

In build-test-qemu, the version of cosa is out of date; the Ignition tests are fetching from the old fixture bucket

[ 19.109940] ignition[897]: INFO : files: createFilesystemsFiles: createFiles: op(3): GET http://rh-kola-fixtures.s3.amazonaws.com/resources/anonymous: attempt #1

I'll see if I can trigger a new build of cosa:4.10 on the cluster

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2022
@travier
Copy link
Member

travier commented Jun 8, 2022

/retitle Bug 2094777: manifest: pull conmon pkg from RHAOS repo for 4.10

@openshift-ci openshift-ci bot changed the title Bug 2094777: manifest: pull conmon pkg from RHAOS repo Bug 2094777: manifest: pull conmon pkg from RHAOS repo for 4.10 Jun 8, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD b7fdd0c and 8 for PR HEAD 0e3cddb in total

@cgwalters
Copy link
Member

Not sure we should block on getting our full CI working for this, we only barely cover conmon via basic podman/crio testing, and those passed.

@miabbott
Copy link
Member

miabbott commented Jun 8, 2022

Not sure we should block on getting our full CI working for this, we only barely cover conmon via basic podman/crio testing, and those passed.

Agreed.

/override ci/prow/build-test-qemu
/override ci/prow/validate

/meow

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@miabbott: cat image

In response to this:

Not sure we should block on getting our full CI working for this, we only barely cover conmon via basic podman/crio testing, and those passed.

Agreed.

/override ci/prow/build-test-qemu
/override ci/prow/validate

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott
Copy link
Member

miabbott commented Jun 8, 2022

I'll see if I can trigger a new build of cosa:4.10 on the cluster

FYI, all cosa tags on the cluster have been updated to latest per branch

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@miabbott: Overrode contexts on behalf of miabbott: ci/prow/build-test-qemu, ci/prow/validate

In response to this:

Not sure we should block on getting our full CI working for this, we only barely cover conmon via basic podman/crio testing, and those passed.

Agreed.

/override ci/prow/build-test-qemu
/override ci/prow/validate

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuijingHei, jmarrero, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [HuijingHei,jmarrero,mike-nguyen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bf606d1 into openshift:release-4.10 Jun 8, 2022
4 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@HuijingHei: All pull requests linked via external trackers have merged:

Bugzilla bug 2094777 has been moved to the MODIFIED state.

In response to this:

Bug 2094777: manifest: pull conmon pkg from RHAOS repo for 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@HuijingHei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate 0e3cddb link true /test validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@HuijingHei HuijingHei deleted the conmon_rhaos branch June 8, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants