Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2103053: ci: Rework to merge all scripts into one #869

Merged
merged 1 commit into from Jul 5, 2022
Merged

Bug 2103053: ci: Rework to merge all scripts into one #869

merged 1 commit into from Jul 5, 2022

Conversation

travier
Copy link
Member

@travier travier commented Jun 29, 2022

Manual backports of changes from master:

  • 8efbd98 ci: Merge all Prow CI "build" scripts into one
  • 787d5da ci: Do not fail on rpm-ostree missing
  • 5e9b2b2 ci: Regroup tests in qemu & metal buckets
  • eb3a605 ci: Prepare and clean-up test names
  • 0a70681 ci: Remove now unused scripts
  • 3d4cf57 ci: Remove Dockerfiles (moved to release)
  • a0e0483 ci/prow-entrypoint: No-op cosa init if already initialized
  • 8cbb015 ci: Add an explicitly named test entry for COSA CI
  • a193baf ci: Remove now unused test names

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2022

@travier: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

ci: Rework to merge all scripts into one

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2022
@travier
Copy link
Member Author

travier commented Jun 29, 2022

Goes with openshift/release#29949

@travier travier mentioned this pull request Jun 29, 2022
Merged
@miabbott
Copy link
Member

Looks like a chicken + egg problem here, so let's merge this first then openshift/release#29949

/lgtm

@miabbott
Copy link
Member

/override ci/prow/build-test-qemu

@travier
Copy link
Member Author

travier commented Jun 30, 2022

/hold

@travier
Copy link
Member Author

travier commented Jun 30, 2022

Let's try a retest first
/retest

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2022
@travier
Copy link
Member Author

travier commented Jun 30, 2022

Sorry @miabbott, I was looking at other PRs. We should be able to merge this one over green CI.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2022

@miabbott: Overrode contexts on behalf of miabbott: ci/prow/build-test-qemu

In response to this:

/override ci/prow/build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
ci: Rework to merge all scripts into one
b129284 
Manual backports of changes from master:

- 8efbd98 ci: Merge all Prow CI "build" scripts into one
- 787d5da ci: Do not fail on rpm-ostree missing
- 5e9b2b2 ci: Regroup tests in qemu & metal buckets
- eb3a605 ci: Prepare and clean-up test names
- 0a70681 ci: Remove now unused scripts
- 3d4cf57 ci: Remove Dockerfiles (moved to release)
- a0e0483 ci/prow-entrypoint: No-op `cosa init` if already initialized
- 8cbb015 ci: Add an explicitly named test entry for COSA CI
- a193baf ci: Remove now unused test names

We can then remove Dockerfile, build-test-qemu.sh & validate.sh once the
release changes are merged.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2022

@travier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@HuijingHei
Copy link
Contributor

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2022
@travier
Copy link
Member Author

travier commented Jul 1, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2022
@travier travier changed the title ci: Rework to merge all scripts into one Bug 2103053: ci: Rework to merge all scripts into one Jul 1, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2022

@travier: This pull request references Bugzilla bug 2103053, which is invalid:

  • expected Bugzilla bug 2103053 to depend on a bug targeting a release in 4.12.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2103053: ci: Rework to merge all scripts into one

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Member Author

travier commented Jul 1, 2022

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2022

@travier: This pull request references Bugzilla bug 2103053, which is invalid:

  • expected Bugzilla bug 2103053 to depend on a bug targeting a release in 4.12.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Member Author

travier commented Jul 1, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2022

@travier: This pull request references Bugzilla bug 2103053, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2103061 is in the state VERIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2103061 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from mike-nguyen July 1, 2022 10:50
@mike-nguyen
Copy link
Member

/lgtm

@mike-nguyen
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuijingHei, miabbott, mike-nguyen, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [HuijingHei,miabbott,mike-nguyen,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@miabbott
Copy link
Member

miabbott commented Jul 5, 2022 •
edited

@aravindhp looks like you are the staff engineer for the CoreOS team; could you provide the staff-eng-approved label?

We got ourselves in a mess with the release-4.11 branch here because the repo wasn't properly enrolled in the Prow branch management.

This is just trying to get the CI jobs on release-4.11 branch back to something functional and reliable. It does not change any code that is going into RHCOS 4.11 or any code already part of RHCOS 4.11.

@mrunalp mrunalp added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jul 5, 2022
@openshift-ci openshift-ci bot merged commit 208aa42 into openshift:release-4.11 Jul 5, 2022
4 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2022

@travier: All pull requests linked via external trackers have merged:

Bugzilla bug 2103053 has been moved to the MODIFIED state.

In response to this:

Bug 2103053: ci: Rework to merge all scripts into one

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier travier deleted the 4.11-ci-backport branch July 5, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-nguyen mike-nguyen mike-nguyen approved these changes

@dustymabe dustymabe Awaiting requested review from dustymabe

@ravanelli ravanelli Awaiting requested review from ravanelli

Assignees

@miabbott miabbott

@HuijingHei HuijingHei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@travier @miabbott @HuijingHei @mike-nguyen @mrunalp