Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix prometheus gather flake #162
Merged
Conversation
|
/approve |
This comment has been minimized.
This comment has been minimized.
openshift-ci-robot
commented
Nov 30, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, meowfaceman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cblecker commentedNov 30, 2019
•
edited
The prometheus state gather test will sometimes flake and fail if one of the files on disk is modified while the tar is running. If tar detects this has happened, it will exit 1 causing the job pod to fail.
I can't find a way to modify this behaviour in tar 1.26 (the
--ignore-failed-readflag doesn't work as expected). Use a bash pipe through to some if logic to prevent this from failing.