Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prometheus gather flake #162

Merged
merged 1 commit into from Nov 30, 2019

Conversation

@cblecker
Copy link
Member

cblecker commented Nov 30, 2019

The prometheus state gather test will sometimes flake and fail if one of the files on disk is modified while the tar is running. If tar detects this has happened, it will exit 1 causing the job pod to fail.

I can't find a way to modify this behaviour in tar 1.26 (the --ignore-failed-read flag doesn't work as expected). Use a bash pipe through to some if logic to prevent this from failing.

@cblecker cblecker force-pushed the cblecker:fix-prom-tar branch from cf663c2 to b1dd446 Nov 30, 2019
Copy link
Collaborator

meowfaceman left a comment

/approve
/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, meowfaceman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9ae937c into openshift:master Nov 30, 2019
1 of 2 checks passed
1 of 2 checks passed
tide Not mergeable. Needs approved label.
Details
ci/prow/verify Job succeeded.
Details
@cblecker cblecker deleted the cblecker:fix-prom-tar branch Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.