Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] WIP merge2 #1068

Closed
wants to merge 3 commits into from
Closed

[DNM] WIP merge2 #1068

wants to merge 3 commits into from

Conversation

tssurya
Copy link
Contributor

@tssurya tssurya commented May 2, 2022

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

@openshift-ci openshift-ci bot requested review from abhat and dcbw May 2, 2022 09:18
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tssurya
To complete the pull request process, please assign knobunc after the PR has been reviewed.
You can assign the PR to them by writing /assign @knobunc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

trozet added 3 commits May 2, 2022 15:00
The nested allocator calls were propagating an error type up during an
IP release. However in the bitmap allocator function it was never
possible to error during an IP release. Remove the return type.

Signed-off-by: Tim Rozet <trozet@redhat.com>
Changes-Include:
 - During pod sync we allocate IPs of all existing pods, but we should
   ignore completed pods
 - During namespace add we add all of the pod IPs to the ns address set,
   but we should ignore completed pods
 - During processing of delete event for a completed pod, we were trying
   to delete the pod again, which would try to free the IP that was
   previously released and could be in use by another pod. We should
   ignore delete events for completed resources as they would have been
   handled during update.
 - On node add, we add all existing pods on that node back to retry as
   an "add". We should skip completed pods here.
 - We now check during deletion of a completed pod (should happen on
   update only) to make sure no other running pods are using this IP as
   a failsafe to ensure we never release an IP in use by another pod or
   the related OVN config

Signed-off-by: Tim Rozet <trozet@redhat.com>
Upon fetching all of the NATs on a router, if the NATs or the router
dont exist this should not be an error for deletion.

Signed-off-by: Tim Rozet <trozet@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2022

@tssurya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration b66b804 link true /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
ci/prow/e2e-aws-ovn-upgrade-local-gateway b66b804 link true /test e2e-aws-ovn-upgrade-local-gateway
ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade b66b804 link true /test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade
ci/prow/4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade b66b804 link false /test 4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-upgrade b66b804 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-windows b66b804 link true /test e2e-aws-ovn-windows
ci/prow/okd-e2e-gcp-ovn b66b804 link false /test okd-e2e-gcp-ovn
ci/prow/e2e-gcp-ovn b66b804 link true /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2022

@tssurya: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tssurya tssurya closed this May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants