Bug 2089392: Update logging for specific policy when creating it #1145
Conversation
All the namespace policies ACLs were being updated when adding a single policy to make sure that the ACL logging levels were current on the policies in case it changed while the policy was being created. This is unnecessary and has performance issues. When creating a policy, only update the ACL logging of that policy, and only if it changed from the value we created it with. The other namespace policies will be handled through the namespace update handler. Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
openshift-ci
bot
added
bugzilla/severity-medium
|
@jcaamano: This pull request references Bugzilla bug 2089392, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
requested review from
anuragthehatter,
abhat and
JacobTanenbaum
openshift-ci
bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jcaamano: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@jcaamano: All pull requests linked via external trackers have merged: Bugzilla bug 2089392 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.10 |
|
@jcaamano: new pull request created: #1149 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cherry-picked from ovn-org/ovn-kubernetes#3011
All the namespace policies ACLs were being updated when adding a single
policy to make sure that the ACL logging levels were current on the
policies in case it changed while the policy was being created. This is
unnecessary and has performance issues.
When creating a policy, only update the ACL logging of that policy, and
only if it changed from the value we created it with. The other
namespace policies will be handled through the namespace update handler.
Signed-off-by: Jaime Caamaño Ruiz jcaamano@redhat.com
- What this PR does and why is it needed
- Special notes for reviewers
- How to verify it
- Description for the changelog