Bug 2118717: [release-4.11] Fix race when adding and removing pod with same name #1247
Conversation
…e informer cache When processing an object in terminal state there is a chance that it was already removed from the API server. Since delete events for objects in terminal state are skipped delete it here. Conflicts: go-controller/pkg/ovn/obj_retry.go Signed-off-by: Patryk Diak <pdiak@redhat.com> (cherry picked from commit f1be8d2)
openshift-ci
bot
added
bugzilla/severity-urgent
|
@flavio-fernandes: This pull request references Bugzilla bug 2118717, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@flavio-fernandes: This pull request references Bugzilla bug 2118717, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm First commit cherry-pick was not clean but the changes are pretty much identical |
|
/approve |
openshift-ci
bot
added
backport-risk-assessed
|
/retest-required |
|
/test e2e-openstack-ovn |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2118717, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@flavio-fernandes unit test is failing: |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Adding and removing a pod on changing nodes back to back can end up in a race where
corresponding logical switch port remains in the wrong logical switch and never gets
properly removed. In order for this to happen, the logical switch port has to have
the same name, which is the <namespace>_<podName>.
Conflicts:
go-controller/pkg/ovn/pods_test.go
Signed-off-by: Flavio Fernandes <flaviof@redhat.com>
Co-authored-by: Tim Rozet <trozet@redhat.com>
(cherry picked from commit be8786a)
flavio-fernandes
force-pushed
the
pod_removal_fix_4.11
branch
from
9f7e6bd
to
88ebb96
Compare
|
/remove-hold |
openshift-ci
bot
removed
the
do-not-merge/hold
my bad. the clean patch apply made me think that the units tests were ok. |
|
/bugzilla refresh |
openshift-ci
bot
added
the
bugzilla/valid-bug
openshift-ci
bot
removed
the
bugzilla/invalid-bug
|
@flavio-fernandes: This pull request references Bugzilla bug 2118717, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@anuragthehatter @rbbratta for FastFix verification and cherry-pick-approval. |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/test e2e-metal-ipi-ovn-dualstack |
|
Backport to 4.10 links : |
|
Clusterbot fails to build PR, pre-merge testing unavailable |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flavio-fernandes, kyrtapz, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-ovn-local-gateway |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/test e2e-aws-ovn-local-gateway |
|
/test e2e-metal-ipi-ovn-ipv6 |
1 similar comment
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/test e2e-openstack-ovn |
|
@dcbw @trozet may we override this test?
CI failure: |
|
@flavio-fernandes: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
merged commit 2c605e0
into
openshift:release-4.11
|
@flavio-fernandes: All pull requests linked via external trackers have merged: Bugzilla bug 2118717 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzila refresh |
|
/bugzilla refresh |
|
@anuragthehatter: Bugzilla bug 2118717 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Adding and removing a pod on changing nodes back to back can end up in a race where
corresponding logical switch port remains in the wrong logical switch and never gets
properly removed. In order for this to happen, the logical switch port has to have
the same name, which is the
<namespace>_<podName>.This PR includes the back-porting of 2 fixes needed to address this race.
They were merged to D/S master via PR #1237