New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-17731: move clearInitialNodeNetworkUnavailableCondition to clustermanager #1839
OCPBUGS-17731: move clearInitialNodeNetworkUnavailableCondition to clustermanager #1839
Conversation
clearInitialNodeNetworkUnavailableCondition needs to be run on every node for GCP. Since we have some nodes that are not running ovn-kubernetes, notably windows, it should be run in the clustermanager Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
@JacobTanenbaum: This pull request references Jira Issue OCPBUGS-17731, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@JacobTanenbaum: This pull request references Jira Issue OCPBUGS-17731, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label acknowledge-critical-fixes-only Without this fix Windows Pods cannot come up on GCP clusters. IOW, we would have to drop Windows container support on GCP without this fix. |
@aravindhp: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flavio-fernandes, JacobTanenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label acknowledge-critical-fixes-only |
/retest image pull backoff issues with build05 cluster |
/retest-required |
/test e2e-aws-ovn-upgrade
|
/test 4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade Failure was due to:
Not sure how this can be flake and not a hard failure. |
/override ci/prow/4.14-upgrade-from-stable-4.13-local-gateway-e2e-aws-ovn-upgrade |
@dcbw: Overrode contexts on behalf of dcbw: ci/prow/4.14-upgrade-from-stable-4.13-local-gateway-e2e-aws-ovn-upgrade, ci/prow/e2e-aws-ovn-local-gateway, ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration, ci/prow/e2e-aws-ovn-upgrade-local-gateway In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration ErrImagePull |
@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade |
@dcbw: Overrode contexts on behalf of dcbw: ci/prow/4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JacobTanenbaum: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4de7881
into
openshift:master
@JacobTanenbaum: Jira Issue OCPBUGS-17731: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-17731 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
clean backport of upstream commit: 87a8c3fa112570ab9c3a20446923cfb908256f18
clearInitialNodeNetworkUnavailableCondition needs to be run on every node for GCP. Since we have some nodes that are not running ovn-kubernetes, notably windows, it should be run in the clustermanager
- What this PR does and why is it needed
- Special notes for reviewers
- How to verify it
- Description for the changelog