Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17731: move clearInitialNodeNetworkUnavailableCondition to clustermanager #1839

Merged

Conversation

JacobTanenbaum
Copy link
Contributor

clean backport of upstream commit: 87a8c3fa112570ab9c3a20446923cfb908256f18
clearInitialNodeNetworkUnavailableCondition needs to be run on every node for GCP. Since we have some nodes that are not running ovn-kubernetes, notably windows, it should be run in the clustermanager

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

clearInitialNodeNetworkUnavailableCondition needs to be run on every
node for GCP. Since we have some nodes that are not running
ovn-kubernetes, notably windows, it should be run in the clustermanager

Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 28, 2023
@openshift-ci-robot
Copy link
Contributor

@JacobTanenbaum: This pull request references Jira Issue OCPBUGS-17731, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

clean backport of upstream commit: 87a8c3fa112570ab9c3a20446923cfb908256f18
clearInitialNodeNetworkUnavailableCondition needs to be run on every node for GCP. Since we have some nodes that are not running ovn-kubernetes, notably windows, it should be run in the clustermanager

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jcaamano August 28, 2023 17:24
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
@JacobTanenbaum
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 28, 2023
@openshift-ci-robot
Copy link
Contributor

@JacobTanenbaum: This pull request references Jira Issue OCPBUGS-17731, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aravindhp
Copy link
Contributor

/label acknowledge-critical-fixes-only

Without this fix Windows Pods cannot come up on GCP clusters. IOW, we would have to drop Windows container support on GCP without this fix.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2023

@aravindhp: The label(s) acknowledge-critical-fixes-only cannot be applied, because the repository doesn't have them.

In response to this:

/label acknowledge-critical-fixes-only

Without this fix Windows Pods cannot come up on GCP clusters. IOW, we would have to drop Windows container support on GCP without this fix.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavio-fernandes
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavio-fernandes, JacobTanenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bparees
Copy link
Contributor

bparees commented Aug 28, 2023

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Aug 28, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d54b889 and 2 for PR HEAD 98d9c11 in total

@dcbw
Copy link
Member

dcbw commented Aug 29, 2023

/retest

image pull backoff issues with build05 cluster

@dcbw
Copy link
Member

dcbw commented Aug 29, 2023

/retest-required
Error: creating EC2 Instance: InsufficientInstanceCapacity

@aravindhp
Copy link
Contributor

/test e2e-aws-ovn-upgrade

Failure:

* 2023-08-29T16:27:15Z 4x kubelet: Failed to pull image "registry.ci.openshift.org/ci/entrypoint-wrapper:latest": rpc error: code = Unknown desc = reading signatures: downloading signatures for sha256:f97422868d1ba862a5d53a61871fe6adad7ac857c3fa107b64143cbb837b990a in registry.ci.openshift.org/ci/entrypoint-wrapper: received unexpected HTTP status: 504 Gateway Time-out
* 2023-08-29T16:25:28Z 3x kubelet: Error: ErrImagePull
* 2023-08-29T16:46:50Z 73x kubelet: Back-off pulling image "registry.ci.openshift.org/ci/entrypoint-wrapper:latest"
* 2023-08-29T16:25:52Z 4x kubelet: Error: ImagePullBackOff 

@aravindhp
Copy link
Contributor

/test 4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade

Failure was due to:

:  [sig-arch][Late] clients should not use APIs that are removed in  upcoming releases [apigroup:apiserver.openshift.io]  [Suite:openshift/conformance/parallel]
{  fail [github.com/openshift/origin/test/extended/apiserver/api_requests.go:110]: user/system:serviceaccount:openshift-oauth-apiserver:oauth-apiserver-sa accessed flowschemas.v1beta2.flowcontrol.apiserver.k8s.io 46 times user/system:serviceaccount:openshift-oauth-apiserver:oauth-apiserver-sa accessed prioritylevelconfigurations.v1beta2.flowcontrol.apiserver.k8s.io 20 times Ginkgo exit error 1: exit with code 1} | 

Run #0:  {  fail [github.com/openshift/origin/test/extended/apiserver/api_requests.go:110]: user/system:serviceaccount:openshift-oauth-apiserver:oauth-apiserver-sa accessed flowschemas.v1beta2.flowcontrol.apiserver.k8s.io 46 times user/system:serviceaccount:openshift-oauth-apiserver:oauth-apiserver-sa accessed prioritylevelconfigurations.v1beta2.flowcontrol.apiserver.k8s.io 20 times Ginkgo exit error 1: exit with code 1} | Run #0: Failed expand_less | 5s | {  fail [github.com/openshift/origin/test/extended/apiserver/api_requests.go:110]: user/system:serviceaccount:openshift-oauth-apiserver:oauth-apiserver-sa accessed flowschemas.v1beta2.flowcontrol.apiserver.k8s.io 46 times user/system:serviceaccount:openshift-oauth-apiserver:oauth-apiserver-sa accessed prioritylevelconfigurations.v1beta2.flowcontrol.apiserver.k8s.io 20 times Ginkgo exit error 1: exit with code 1}

Not sure how this can be flake and not a hard failure.

@dcbw
Copy link
Member

dcbw commented Aug 29, 2023

/override ci/prow/4.14-upgrade-from-stable-4.13-local-gateway-e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-local-gateway
/override ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration
/override ci/prow/e2e-aws-ovn-upgrade-local-gateway

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2023

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/4.14-upgrade-from-stable-4.13-local-gateway-e2e-aws-ovn-upgrade, ci/prow/e2e-aws-ovn-local-gateway, ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration, ci/prow/e2e-aws-ovn-upgrade-local-gateway

In response to this:

/override ci/prow/4.14-upgrade-from-stable-4.13-local-gateway-e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-local-gateway
/override ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration
/override ci/prow/e2e-aws-ovn-upgrade-local-gateway

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Member

dcbw commented Aug 29, 2023

/override ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration

ErrImagePull

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2023

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration

In response to this:

/override ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration

ErrImagePull

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Member

dcbw commented Aug 30, 2023

/override ci/prow/4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2023

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade

In response to this:

/override ci/prow/4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2023

@JacobTanenbaum: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-kubevirt 98d9c11 link false /test e2e-aws-ovn-kubevirt
ci/prow/e2e-openstack-ovn 98d9c11 link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4de7881 into openshift:master Aug 30, 2023
27 of 29 checks passed
@openshift-ci-robot
Copy link
Contributor

@JacobTanenbaum: Jira Issue OCPBUGS-17731: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17731 has been moved to the MODIFIED state.

In response to this:

clean backport of upstream commit: 87a8c3fa112570ab9c3a20446923cfb908256f18
clearInitialNodeNetworkUnavailableCondition needs to be run on every node for GCP. Since we have some nodes that are not running ovn-kubernetes, notably windows, it should be run in the clustermanager

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants