Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Pre merge testing for ANP metrics #2125

Closed
wants to merge 8 commits into from

Conversation

tssurya
Copy link
Contributor

@tssurya tssurya commented Apr 16, 2024

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Remove the local files we use for maintaining
the ANP yamls as they don't really serve any purpose.
We can just curl install the yamls directly from
the k8s repo.

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
This commit ensures that when a node goes away, the zone goes away,
we delete the corresponding statuses from all ANPs and BANP in
the cluster.

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
@tssurya tssurya requested a review from dcbw as a code owner April 16, 2024 14:20
@openshift-ci openshift-ci bot requested a review from jcaamano April 16, 2024 14:30
Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

@tssurya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security a8a36d1 link false /test security
ci/prow/e2e-metal-ipi-ovn-ipv6 a8a36d1 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn a8a36d1 link true /test e2e-gcp-ovn
ci/prow/4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade a8a36d1 link true /test 4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-serial a8a36d1 link true /test e2e-aws-ovn-serial
ci/prow/okd-e2e-gcp-ovn a8a36d1 link false /test okd-e2e-gcp-ovn
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway a8a36d1 link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-azure-ovn-upgrade a8a36d1 link true /test e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tssurya tssurya closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants