Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update OWNERS #29

Merged
merged 1 commit into from Oct 4, 2019
Merged

Conversation

danwinship
Copy link
Contributor

Sync (mostly) to the updated SDN/CNO OWNERS files; add @alexanderConstantinescu and @rcarrillocruz as reviewers, add @squeed and @knobunc as approvers, and alphabetize.

/cc @squeed

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 4, 2019
@squeed
Copy link
Contributor

squeed commented Oct 4, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0eeaef0 into openshift:master Oct 4, 2019
Billy99 added a commit to Billy99/ovn-kubernetes that referenced this pull request Nov 2, 2022
Rework openshift#29 to handle both one IP address and multiple. openshift#29 only fixed the
multiple IP case.

While in the code, fixed a few other things:
* There were several places that the script called the same `kubectl` command
  multiple times in a row. Updated to call once and save output, then parse
  the output multiple ways using.
* Replaced `VAR=\`<commmand>\`` to `VAR=$(<commmand>)` based on review of patch
  in Submariner.
* Preserve the current context when running mctest.sh.

Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants