Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1887456: 11-20-2020 merge #357

Merged
merged 22 commits into from Nov 21, 2020

Conversation

trozet
Copy link
Contributor

@trozet trozet commented Nov 19, 2020

Includes fixes for:

  1. shared gw mode flows for ingress to pods
  2. local gateway moving to normal flows from flood
  3. fixes icmpv6 flooding in shared bridge flows
  4. fix network policy when the namespace label changes
  5. fixes for CNI with ADD failures related to using a namespace that starts with a number

anfredette and others added 16 commits November 10, 2020 10:02
Signed-off-by: Andre Fredette <afredette@redhat.com>
This will run 3 e2e jobs twice a day on master. It will run
with HA and local gateway across each of ipv4, ipv6 and dual
stack.

With these jobs we can better track the health of CI instead
of only looking at jobs that run on PRs which may or may not
be healthy themselves.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Re-orders test code to make sure handler is added before
the updates are sent. This way we certain that if this test
fails, the missing node update did not get dropped between
spawning the routine that triggers updates and adding the
handler.

Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Signed-off-by: Dan Williams <dcbw@redhat.com>
Following the changes for shared gw mode from:
ovn-org/ovn-kubernetes#1774

This behavior will allow NORMAL action for all packets not destined to
the shared gw mac, thus allowing an non-ovn port to be attached to the
shared gw bridge and function normally.

Signed-off-by: Tim Rozet <trozet@redhat.com>
Looks like '* */12 * * *' is what would run ovn-ci every
minute past the 12th hour instead of just every 12
hours. It's not actually running it that fast (probably
getting throttled). '0 */12 * * *' will run the job
every 00:00 and 12:00 which is what I'm looking for.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Changes local gateway flows to NORMAL action
Our flows for flooding icmpv6 to both OVN and the host were too generic.
This caused ICMPv6 echo requests to be sent to both, resulting in a
duplicate ack and other issues. This patch changes the flows for icmpv6
to be more specific and target only flooding for Neighbor Advertisements
and Route Advertisements. This will allow OVN to receive only the
packets it needs for peering/discovery, while all other ICMPv6 will go to
the host only.

Signed-off-by: Tim Rozet <trozet@redhat.com>
We already do this in local GW mode, but it was missing in shared GW
mode. For ingress traffic coming into the node that is destined for pod
subnet, it needs to be routed into OVN so that the traffic can make it
to the pods. Note this is only for when we are not using SNAT with
multiple gateways.

Signed-off-by: Tim Rozet <trozet@redhat.com>
…_flows_shared_gw

Adds pod subnet flows on shared gw bridge
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@trozet trozet changed the title 11-19-2020 merge Bug 1887456: 11-19-2020 merge Nov 19, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 19, 2020
@openshift-ci-robot
Copy link
Contributor

@trozet: This pull request references Bugzilla bug 1887456, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1887456: 11-19-2020 merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trozet
Copy link
Contributor Author

trozet commented Nov 19, 2020

@dcbw @danwinship PTAL

@trozet
Copy link
Contributor Author

trozet commented Nov 20, 2020

/retest

Currently when using a namespaceSelector and podSelector in the same network
policy when changing the labels of the namespace nothing happens.
Correct the operation so that when updating the label removes a
namespace from a network policy the pods are correctly removed

Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
@trozet
Copy link
Contributor Author

trozet commented Nov 20, 2020

/retest

trozet and others added 3 commits November 20, 2020 10:05
fix network policy when the namespace label changes
Sometimes OVS decides to put quotes around external ids:
https://bugzilla.redhat.com/show_bug.cgi?id=1899746

Signed-off-by: Tim Rozet <trozet@redhat.com>
factory: Fix informer inital adds and subsequent updates test
@trozet trozet changed the title Bug 1887456: 11-19-2020 merge Bug 1887456: 11-20-2020 merge Nov 21, 2020
@openshift-ci-robot
Copy link
Contributor

@trozet: This pull request references Bugzilla bug 1887456, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1887456: 11-20-2020 merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 21, 2020

@trozet: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere-ovn c6f39a3 link /test e2e-vsphere-ovn
ci/prow/e2e-openstack-ovn c6f39a3 link /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dcbw
Copy link
Member

dcbw commented Nov 21, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dcbw
Copy link
Member

dcbw commented Nov 21, 2020

/override ci/prow/e2e-metal-ipi-ovn-dualstack

The job failure is being tracked by https://bugzilla.redhat.com/show_bug.cgi?id=1895909

@openshift-ci-robot
Copy link
Contributor

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-metal-ipi-ovn-dualstack

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-dualstack

The job failure is being tracked by https://bugzilla.redhat.com/show_bug.cgi?id=1895909

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 32a4663 into openshift:master Nov 21, 2020
@openshift-ci-robot
Copy link
Contributor

@trozet: All pull requests linked via external trackers have merged:

Bugzilla bug 1887456 has been moved to the MODIFIED state.

In response to this:

Bug 1887456: 11-20-2020 merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Member

dcbw commented Nov 21, 2020

openstack failed because bootstrap didn't bring up one of the nodes; didn't even get far enough to start networking.

vsphere failed in bootstrap before networking started too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants