New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2022043: [4.8z] Avoid stale annotations by re-subscribing to netlink #829
Bug 2022043: [4.8z] Avoid stale annotations by re-subscribing to netlink #829
Conversation
@flavio-fernandes: This pull request references Bugzilla bug 2022043, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
430f86e
to
245fa3b
Compare
/bugzilla refresh |
@flavio-fernandes: This pull request references Bugzilla bug 2022043, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @kyrtapz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest |
/retest-required |
/retest |
Signed-off-by: Dan Williams <dcbw@redhat.com> (cherry picked from commit aecf6a4)
…)*kapi.Node There is no need for SetAnnotationsOnNode to take the API object as a parameter, it only uses the node name. Signed-off-by: Patryk Diak <pdiak@redhat.com> (cherry picked from commit a4c05c2)
…notations(map[string]interface{}) There is no need for SetAnnotationsOnNamespace to take the API object as a parameter, it only uses the namespace name. Values of annotations should be of interface{} type to allow for annotation removal. Conflicts: go-controller/pkg/kube/annotator.go go-controller/pkg/kube/kube.go go-controller/pkg/kube/mocks/Interface.go Signed-off-by: Patryk Diak <pdiak@redhat.com> (cherry picked from commit 281e463)
Values of annotations should be of interface{} type to allow for annotation removal. Conflicts: go-controller/pkg/kube/kube_test.go Signed-off-by: Patryk Diak <pdiak@redhat.com> (cherry picked from commit d5f6f16)
Node annotator used the node object to compare its annotations with the changes provided. Because the object isn't synchronized with the API server, the comparison used potentially outdated values. This change removes the logic of comparing existing annotations and only caches provided changes to send them with Run(). Conflicts: go-controller/pkg/node/gateway_init_linux_test.go go-controller/pkg/node/management-port_linux_test.go go-controller/pkg/node/node.go go-controller/pkg/kube/annotator.go Signed-off-by: Patryk Diak <pdiak@redhat.com> (cherry picked from commit f472725)
Pod annotator used the pod object to compare its annotations with the changes provided. Because the object isn't synchronized with the API server, the comparison used potentially outdated values. This change removes the logic of comparing existing annotations and only caches provided changes to send them with Run(). Signed-off-by: Patryk Diak <pdiak@redhat.com> (cherry picked from commit 0674db6)
Namespace annotator used the namespace object to compare its annotations with the changes provided. Because the object isn't synchronized with the API server, the comparison used potentially outdated values. This change removes the logic of comparing existing annotations and only caches provided changes to send them with Run(). Signed-off-by: Patryk Diak <pdiak@redhat.com> (cherry picked from commit ef70691)
Signed-off-by: Patryk Diak <pdiak@redhat.com> (cherry picked from commit 96640b8)
…change 1. Create nodeAnnotator in newAddressManager instead of using an existing one, this avoids sending annotations that were added by other components. 2. Modify addressManager so it will try to set the annotations only if there was an actual change, not on every netlink notification. 2. Remove redundant nodeIPManager creation from gateway_init.go. Conflicts: go-controller/pkg/node/gateway_init.go go-controller/pkg/node/gateway_init_linux_test.go go-controller/pkg/node/gateway_shared_intf.go go-controller/hybrid-overlay/pkg/controller/master_test.go go-controller/hybrid-overlay/pkg/util/util.go go-controller/pkg/node/gateway_init.go go-controller/pkg/node/gateway_init_linux_test.go go-controller/pkg/node/gateway_shared_intf.go Signed-off-by: Patryk Diak <pdiak@redhat.com> (cherry picked from commit f57c2c1)
This PR is not the real fix. It includes better logging should this issue happen again. The real fix has already been done via PR ovn-org/ovn-kubernetes#2521 for the changes on bug 1998515. Signed-off-by: Flavio Fernandes <flaviof@redhat.com> (cherry picked from commit 9b4d436)
This PR ensures that address callbacks for node IP handler are not missed by re-subscribing for address updates from netlink in case of errors and also by explicitly calling sync after an initial timeout. Signed-off-by: Flavio Fernandes <flaviof@redhat.com> Co-Authored-By: Andrew Stoycos <astoycos@redhat.com> (cherry picked from commit ebce1b2)
prevent ovn syncNodeGateway from failing on missing host-addresses annotations. Instead, proceeed with syncing ovn gateway without additional addresses. Signed-off-by: Adrian Chiris <adrianc@nvidia.com> (cherry picked from commit d8057cf)
5aca4c7
to
9fbd0b6
Compare
da2af67
to
8ea7ced
Compare
/retest-required Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/test e2e-metal-ipi-ovn-dualstack |
/test 4.8-upgrade-from-stable-4.7-e2e-aws-ovn-upgrade |
@flavio-fernandes: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2022043, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/test 4.8-upgrade-from-stable-4.7-e2e-aws-ovn-upgrade |
/bugzilla refresh |
@abhat: This pull request references Bugzilla bug 2022043, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@abhat: This pull request references Bugzilla bug 2022043, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label cherry-pick-approved |
/label qe-approved |
@flavio-fernandes: All pull requests linked via external trackers have merged: Bugzilla bug 2022043 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR includes the fixed needed for bug 2022043, including its dependencies.