Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.7] Bug 2034506: Make config parsing more resilient for unknown fields #882

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #868

/assign creydr

Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
(cherry picked from commit 4392857)
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

@openshift-cherrypick-robot: Bugzilla bug 2030465 has been cloned as Bugzilla bug 2034506. Retitling PR to link against new bug.
/retitle [release-4.7] [release-4.8] Bug 2034506: Make config parsing more resilient for unknown fields

In response to this:

[release-4.7] [release-4.8] Bug 2030465: Make config parsing more resilient for unknown fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.7] [release-4.8] Bug 2030465: Make config parsing more resilient for unknown fields [release-4.7] [release-4.8] Bug 2034506: Make config parsing more resilient for unknown fields Dec 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2034506, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2030465 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2030465 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

[release-4.7] [release-4.8] Bug 2034506: Make config parsing more resilient for unknown fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 21, 2021
@creydr
Copy link
Member

creydr commented Dec 21, 2021

/retitle [release-4.7] Bug 2034506: Make config parsing more resilient for unknown fields

@openshift-ci openshift-ci bot changed the title [release-4.7] [release-4.8] Bug 2034506: Make config parsing more resilient for unknown fields [release-4.7] Bug 2034506: Make config parsing more resilient for unknown fields Dec 21, 2021
@creydr
Copy link
Member

creydr commented Dec 21, 2021

/retest

@creydr
Copy link
Member

creydr commented Dec 21, 2021

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alexanderConstantinescu
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 11, 2022
@trozet
Copy link
Contributor

trozet commented Jan 12, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2022
@trozet
Copy link
Contributor

trozet commented Jan 12, 2022

@anuragthehatter can you add the cherry pick approved please?

@zhaozhanqi
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 13, 2022
@openshift-merge-robot openshift-merge-robot merged commit 4c605d3 into openshift:release-4.7 Jan 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2034506 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 2034506: Make config parsing more resilient for unknown fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@creydr
Copy link
Member

creydr commented Jan 26, 2022

/cherry-pick release-4.6

@openshift-cherrypick-robot
Copy link
Author

@creydr: new pull request created: #929

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants