Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and own /etc/issue.d #29

Merged

Conversation

Projects
None yet
5 participants
@rfairley
Copy link
Contributor

commented Mar 19, 2019

Bring the changes from #18 into the ootpa version.

I had originally meant for this to go into ootpa only, and should have opened against the ootpa branch. Will open a PR to revert #18, as the change is not needed in maipo.

Tested by installing an RPM with this change into an ootpa RHCOS image - ownership by redhat-release-coreos is applied correctly to /etc/issue.d.

Create and own /etc/issue.d
agetty displays messages in /etc/issue.d, and is the mechanism
that will show messages from the
[console-login-helper-messages](https://github.com/rfairley/console-login-helper-messages)
package (in ootpa only).

Related change in Fedora: https://src.fedoraproject.org/rpms/fedora-release/pull-request/64
@ashcrow
Copy link
Member

left a comment

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Mar 19, 2019

@ashcrow: GitHub didn't allow me to request PR reviews from the following users: yuqi-zhang.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ashcrow

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

/cc @yuqi-zhang PTAL as well

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Mar 19, 2019

@ashcrow: GitHub didn't allow me to request PR reviews from the following users: yuqi-zhang.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuqi-zhang

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

LGTM! I do not seem to have perms to review the PR through github though

@ashcrow

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 2032509 into openshift:ootpa Mar 19, 2019

1 check was pending

tide Not mergeable.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.