Adding a commandline graph pruner

[bradmwilliams]

Adding a couple commandline options to prune, and verify, the release-upgrade-graph. Calling the release-controller like:
./release-controller --release-namespace ocp --job-namespace ci --prune-graph, will fetch all the tags from the release imagestream. Then it finds the tags that are NOT present in either of the TO and FROM upgrade graphs. Then, it generates the union of the 2 lists, and prunes the graph accordingly. Lastly, by default, it will pretty print the resultant graph for verification. Optionally, you can also specify the --print-secret-payload option to print out the base64 output of the compressed graph.

[bradmwilliams]

/assign @smarterclayton

[bradmwilliams]

/hold This shouldn't be merged until the secret has been pruned and the latest state gets saved.

[smarterclayton]

Squash the code review changes and then this lgtm

[smarterclayton]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

New changes are detected. LGTM label has been removed.

[bradmwilliams]

/unhold

[smarterclayton]

Why are you passing a buf into this method here?

[bradmwilliams]

The original logic creates the buffer and then resets it for each iteration of the wait.Until() loop:

release-controller/cmd/release-controller/upgrades.go

Lines 328 to 349 in 3648252

	// keep the secret up to date
	buf := &bytes.Buffer{}
	wait.Until(func() {
	buf.Reset()
	if err := graph.Save(buf); err != nil {
	klog.Errorf("Unable to calculate graph state: %v", err)
	return
	}
	secret, err := secretClient.Get(context.TODO(), name, metav1.GetOptions{})
	if err != nil {
	klog.Errorf("Can't read latest secret %s/%s: %v", ns, name, err)
	return
	}
	if secret.Data == nil {
	secret.Data = make(map[string][]byte)
	}
	secret.Data["latest"] = buf.Bytes()
	if _, err := secretClient.Update(context.TODO(), secret, metav1.UpdateOptions{}); err != nil {
	klog.Errorf("Can't save state to secret %s/%s: %v", ns, name, err)
	}
	klog.V(2).Infof("Saved upgrade graph state to %s/%s", ns, name)
	}, 5*time.Minute, stopCh)

When I refactored the code, I extracted the "save" logic into saveUpgradeGraph() and to preserve the original logic, I passed in the *bytes.Buffer.

[bradmwilliams]

/remove-lifecycle stale

[bradmwilliams]

/hold
Need to test with the latest/greatest changes

[bradmwilliams]

/unhold

[openshift-ci]

@bradmwilliams: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexNPavel, bradmwilliams, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AlexNPavel,bradmwilliams,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment