Skip to content

Adding Jira Bot's email address to prevent duplicate messages#770

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bradmwilliams:jira-bot-fix
Jun 3, 2026
Merged

Adding Jira Bot's email address to prevent duplicate messages#770
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bradmwilliams:jira-bot-fix

Conversation

@bradmwilliams

@bradmwilliams bradmwilliams commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED

Summary by CodeRabbit

  • Bug Fixes
    • Resolved an issue causing duplicate JIRA comments when release automation updates issues.

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b04270d9-4fce-40b8-964d-ca9f442d3528

📥 Commits

Reviewing files that changed from the base of the PR and between afdecba and 04c7205.

📒 Files selected for processing (1)
  • pkg/jira/jira.go

📝 Walkthrough

Walkthrough

The commentIssue function's bot-author detection logic is expanded to recognize an additional bot email address (openshift-release-controller-jira-bot@redhat.com) when scanning existing JIRA comments, preventing duplicate comment posting when the bot author identity varies.

Changes

JIRA bot-author email expansion

Layer / File(s) Summary
Bot-author email recognition
pkg/jira/jira.go
The conditional identifying the release-controller bot author is broadened to treat an additional email address as a known bot identity, preventing duplicate comments across varying bot author configurations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A tiny email joins the fold,
The release bot's name now twofold,
No more duplication's curse,
JIRA comments flow, not reverse! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly describes the main change: adding a Jira bot email address to prevent duplicate messages, which matches the file change that broadens bot-author detection logic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Command failed


Comment @coderabbitai help to get the list of available commands and usage tips.

@hoxhaeris

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot requested review from AlexNPavel and hoxhaeris June 3, 2026 15:34
@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, hoxhaeris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bradmwilliams,hoxhaeris]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jun 3, 2026
@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@bradmwilliams: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 5e1a9f0 into openshift:main Jun 3, 2026
9 checks passed
@bradmwilliams bradmwilliams deleted the jira-bot-fix branch June 3, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants