Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Include 'digest' in release stream JSON #92

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@tbielawa
Copy link
Member

commented May 18, 2019

Automating release signing will be simpler if the release stream
includes the digest information as well.

Work in progress. I'm not sure what to do about digest, _ := c.digestForArtifacts(latest.Name)

I could use some help with that part.

Include 'digest' in release stream JSON
Automating release signing will be simpler if the release stream
includes the digest information as well.
@openshift-ci-robot

This comment has been minimized.

Copy link

commented May 18, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tbielawa
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

This comment has been minimized.

Copy link

commented May 18, 2019

@tbielawa: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/images 469b6f0 link /test images

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tbielawa

This comment has been minimized.

Copy link
Member Author

commented May 18, 2019

/hold

@tbielawa

This comment has been minimized.

Copy link
Member Author

commented May 18, 2019

Also it would be cool if we could include the canonical client download location in there

clientsDownloadURL: https://mirror.openshift.com/pub/openshift-v4/clients/ocp/${NAME}

My initial thought on that, if we change that location in the future then we'd have to update the code as well. Thoughts on that?
Also clientsDownloadURL is specific. We also include the installers in there. I'm open to a better name, and not offended if you shoot this idea down entirely @smarterclayton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.