From 57f248f55f40126e717c1f2079b304bdc64e3250 Mon Sep 17 00:00:00 2001
From: Derek Higgins <derekh@redhat.com>
Date: Mon, 29 Apr 2024 16:40:12 +0100
Subject: [PATCH] OCPBUGS-33091: Only place the VM storage pools on small
 second disks (#51453)

* Test access to API during devscripts-gather

devscripts gather has access to the API without going
through the proxy.

* Only place the VM storage pools on small second disks

If the disk on a virt hosts are less then 200G then it
can't store both the VM storage pools and the image
registry.
---
 .../baremetalds-devscripts-gather-commands.sh       |  3 +++
 .../setup/baremetalds-devscripts-setup-commands.sh  | 13 +++++++++++--
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/ci-operator/step-registry/baremetalds/devscripts/gather/baremetalds-devscripts-gather-commands.sh b/ci-operator/step-registry/baremetalds/devscripts/gather/baremetalds-devscripts-gather-commands.sh
index 0a33525a67f7..336ddf82e064 100644
--- a/ci-operator/step-registry/baremetalds/devscripts/gather/baremetalds-devscripts-gather-commands.sh
+++ b/ci-operator/step-registry/baremetalds/devscripts/gather/baremetalds-devscripts-gather-commands.sh
@@ -27,6 +27,9 @@ echo "### Gathering logs..."
 timeout -s 9 15m ssh "${SSHOPTS[@]}" "root@${IP}" bash - <<EOF |& sed -e 's/.*auths.*/*** PULL_SECRET ***/g'
 cd dev-scripts
 
+echo "Testing API access"
+oc get clusterversion || true
+
 echo "Get install-gather, if there is one..."
 cp /root/dev-scripts/ocp/*/log-bundle*.tar.gz /tmp/artifacts/log-bundle-\$HOSTNAME.tar.gz || true
 
diff --git a/ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh b/ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh
index 7aa695dedd07..680ec9a15edb 100644
--- a/ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh
+++ b/ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh
@@ -315,8 +315,17 @@ then
   # There may have only been one disk
   if [ -n "\$DATA_DISK" ] ; then
     mkfs.xfs -f "\${DATA_DISK}"
-    mkdir /opt/dev-scripts
-    mount "\${DATA_DISK}" /opt/dev-scripts
+
+    DATA_DISK_SIZE=\$(lsblk -o size --noheadings --bytes -d \${DATA_DISK})
+    # If there is a data disk but its less the 200G, its not big enough for both
+    # the storage pools and the registry, just place the pool on it.
+    if [ "\$DATA_DISK_SIZE" -lt "$(( 1024 ** 3 * 200 ))" ] ; then
+        mkdir -p /opt/dev-scripts/pool
+        mount "\${DATA_DISK}" /opt/dev-scripts/pool
+    else
+        mkdir /opt/dev-scripts
+        mount "\${DATA_DISK}" /opt/dev-scripts
+    fi
   fi
 elif [ ! -z "${NVME_DEVICE}" ] && [ -e "${NVME_DEVICE}" ] && [[ "\$(mount | grep ${NVME_DEVICE})" == "" ]];
 then