Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1943804: new CI job for the encryption rotation tests #18554

Conversation

p0lyn0mial
Copy link
Contributor

@p0lyn0mial p0lyn0mial commented May 13, 2021

The new CI job will shorten the overall time needed to test encryption but also will increase the pass rate of the tests as we have seen them frequently failing to due to a timeout.

The new tests are defined in openshift/cluster-kube-apiserver-operator#1131

@p0lyn0mial p0lyn0mial changed the title new CI job for the encryption rotation tests Bug 1943804: new CI job for the encryption rotation tests May 13, 2021
@openshift-ci openshift-ci bot requested review from deads2k and sttts May 13, 2021 09:37
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2021

@p0lyn0mial: This pull request references Bugzilla bug 1943804, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

Bug 1943804: new CI job for the encryption rotation tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 13, 2021
@openshift-ci openshift-ci bot requested a review from wangke19 May 13, 2021 09:37
The new CI job will shorten the overall time needed to test encryption but also will increase the pass rate of the tests as we have seen them frequently failing to due to a timeout.
@p0lyn0mial p0lyn0mial force-pushed the kas-o-split-encryption-tests branch from 89c9149 to 36d1929 Compare May 13, 2021 09:39
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2021

@p0lyn0mial: This pull request references Bugzilla bug 1943804, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

Bug 1943804: new CI job for the encryption rotation tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member

mfojtik commented May 13, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2021
@openshift-merge-robot openshift-merge-robot merged commit 785ea34 into openshift:master May 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2021

@p0lyn0mial: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-kube-apiserver-operator-master.yaml using file ci-operator/config/openshift/cluster-kube-apiserver-operator/openshift-cluster-kube-apiserver-operator-master.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-kube-apiserver-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-kube-apiserver-operator/openshift-cluster-kube-apiserver-operator-master-presubmits.yaml

In response to this:

The new CI job will shorten the overall time needed to test encryption but also will increase the pass rate of the tests as we have seen them frequently failing to due to a timeout.

The new tests are defined in openshift/cluster-kube-apiserver-operator#1131

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2021

@p0lyn0mial: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1943804 has not been moved to the MODIFIED state.

In response to this:

Bug 1943804: new CI job for the encryption rotation tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
3 participants