Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cri-o over to the prow dco plugin #3405

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
4 participants
@cblecker
Copy link
Member

cblecker commented Apr 9, 2019

/hold
/assign @stevekuznetsov
/cc @mrunalp

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 11, 2019

/retest

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 11, 2019

@stevekuznetsov Not sure what's up here. Running checkconfig locally doesn't throw this error. Are we using an updated version of checkconfig?

@stevekuznetsov

This comment has been minimized.

Copy link
Contributor

stevekuznetsov commented Apr 11, 2019

/retest

@stevekuznetsov

This comment has been minimized.

Copy link
Contributor

stevekuznetsov commented Apr 11, 2019

/lgtm
/approve

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 11, 2019

/retest

@stevekuznetsov

This comment has been minimized.

Copy link
Contributor

stevekuznetsov commented Apr 11, 2019

/lgtm
/approve
/hold cancel
/retest

@cblecker cblecker force-pushed the cblecker:dco-plugin branch from 187b949 to 68e45e0 Apr 11, 2019

@cblecker cblecker force-pushed the cblecker:dco-plugin branch from 68e45e0 to eb33aeb Apr 11, 2019

@cblecker cblecker force-pushed the cblecker:dco-plugin branch from eb33aeb to db6e914 Apr 11, 2019

@stevekuznetsov

This comment has been minimized.

Copy link
Contributor

stevekuznetsov commented Apr 11, 2019

/lgtm
/woof

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Apr 11, 2019

@stevekuznetsov: dog image

In response to this:

/lgtm
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Apr 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 667823f into openshift:master Apr 11, 2019

10 checks passed

ci/prow/ci-operator-config Job succeeded.
Details
ci/prow/config Job succeeded.
Details
ci/prow/correctly-sharded-config Job succeeded.
Details
ci/prow/generated-config Job succeeded.
Details
ci/prow/ordered-prow-config Job succeeded.
Details
ci/prow/owners Job succeeded.
Details
ci/prow/pj-rehearse Job succeeded.
Details
ci/prow/prow-config-filenames Job succeeded.
Details
ci/prow/prow-config-semantics Job succeeded.
Details
tide In merge pool.
Details
@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Apr 11, 2019

@cblecker: Updated the following 3 configmaps:

  • config configmap in namespace ci using the following files:
    • key config.yaml using file cluster/ci/config/prow/config.yaml
  • labels configmap in namespace ci using the following files:
    • key labels.yaml using file cluster/ci/config/prow/labels.yaml
  • plugins configmap in namespace ci using the following files:
    • key plugins.yaml using file cluster/ci/config/prow/plugins.yaml

In response to this:

/hold
/assign @stevekuznetsov
/cc @mrunalp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker cblecker deleted the cblecker:dco-plugin branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.